fix nxos_vrf and migrate get_interface_type to module_utils #40825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
trishnaguha
removed
the
needs_triage
|
The test |
ansibot
added
ci_verified
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
trishnaguha
force-pushed
the
nxos_vrf_fix_for_vlan_interface
branch
from
e0fbd63
to
4c52bed
Compare
ansibot
added
core_review
|
cherry-picked to 2.6 and 2.5 |
trishnaguha
added a commit
that referenced
this pull request
May 30, 2018
* httpapi fix nxos (#40806) * httpapi fix nxos Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * nxos_hsrp fix Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit a7421e8) * fix nxos_vrf and migrate get_interface_type to module_utils (#40825) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit b4baa2d) * nxos_vlan fix (#40822) * nxos_vlan fix Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * uncomment mode test as nxapi now has get_capabilities Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 17b6ecf) * Update nxos_install_os module (#40102) * Add nxos_install_os integration tests * Update call to check timers * Update check_ansible_timer method * Modify network_cli integration tests * Add timer check for nxos_install_os * Add comments for clear_persistent_sockets * Update connection info for tests * More updates * Restructure files for provider and non-provider testing * Update env var name and add check for ISSU switchover (cherry picked from commit 9f02630)
trishnaguha
added a commit
that referenced
this pull request
May 30, 2018
* Fix legacy Nexus 3k integration test and module issues. (#40322) * Add setup ignore_errors for nxos_config test * Fix parse_fan_info for n3k * Skip bidir tests for N3k * Omit vni config for n3k * Skip unsupported nxos_vrf_af test on N3K * Add legacy N3K platform tag (cherry picked from commit 63e1643) * Skip N35 and N3L platforms for nxos_evpn_global test (#40333) (cherry picked from commit ad69ef8) * add normalize_interface in module_utils and fix nxos_l3_interface module (#40598) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 0b7932d) * nxos_interface: Disable switchport for loopback/svi (#40314) * nxos_interface: Disable switchport for loopback/svi * Replace interface_type with get_interface_type(name) (cherry picked from commit d04a989) * fixes bug with matching nxos prompts (#40655) This change addresses an issue where the prompt matching regular expressions would not match a prompt if the hostname starts with a numeric value. Before this change, the connection would fail with a socket.timeout() error. This change updates the termnal_stdout_re values to now check for a number. See Github issue #38639 (cherry picked from commit d829ff6) * fix nxos_vrf and migrate get_interface_type to module_utils (#40825) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit b4baa2d) * nxos_vlan fix Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * changelog nxos bugfixes 2.5.4 Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
gothicx
pushed a commit
to gothicx/ansible
that referenced
this pull request
Jun 9, 2018
…40825) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
…40825) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Trishna Guha trishnaguha17@gmail.com
SUMMARY
fixes #40713
migrate
get_interface_typeto module_utilsISSUE TYPE
COMPONENT NAME
modules/network/nxos/nxos_vrf
module_utils/network/nxos/nxos.py
ANSIBLE VERSION