Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cryptsetup module #40406

Closed
wants to merge 2 commits into from
Closed

Add cryptsetup module #40406

wants to merge 2 commits into from

Conversation

t2d
Copy link

@t2d t2d commented May 18, 2018

SUMMARY

Adds a wrapper module around cryptsetup to manage plain dm-crypt and LUKS encrypted volumes

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

cryptsetup

ANSIBLE VERSION
ansible 2.6.0 (devel efe7c20100) last updated 2018/04/27 15:45:56 (GMT +200)
ADDITIONAL INFORMATION

Please give me feedback on how to improve this module.

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels May 18, 2018
@ansibot
Copy link
Contributor

ansibot commented May 18, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/system/cryptsetup.py:0:0: E307 version_added should be 2.6. Currently 2.4
lib/ansible/modules/system/cryptsetup.py:0:0: E312 No RETURN provided

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 18, 2018
@ansibot
Copy link
Contributor

ansibot commented May 18, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/system/cryptsetup.py:84:7: E225 missing whitespace around operator

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented May 18, 2018

@AugustusKling @ColOfAbRiX @DavidWittman @EvanK @LinusU @abulimov @adejoux @ahtik @azaghal @bgurney-rh @dankeder @davixx @dougluce @dsummersl @giovannisciortino @goozbach @groks @haad @hryamzik @indrajitr @jasperla @jhoekx @jsumners @jtyr @kairoaraujo @kevensen @lberruti @matze @mcv21 @molekuul @mpdehaan @mulby @natefoo @nibalizer @obourdon @ovcharenko @pilou- @pmarkham @pyykkis @risaacson @rosmo @saito-hideki @sebastiendarocha @sfromm @srvg @tdtrask @tmshn @xen0l

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 18, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label May 24, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 1, 2018
@ansibot ansibot added the system System category label Feb 17, 2019
@t2d
Copy link
Author

t2d commented May 28, 2019

superseded by #48991

@t2d t2d closed this May 28, 2019
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. system System category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t2d @ansibot @jborean93