Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GitHub Enterprise for github_deploy_key #40411

Closed
wants to merge 2 commits into from
Closed

Add support for GitHub Enterprise for github_deploy_key #40411

wants to merge 2 commits into from

Conversation

dcode
Copy link
Contributor

@dcode dcode commented May 18, 2018

SUMMARY

I use GitHub Enterprise and would like to use the Ansible modules to manage deploy keys and such. The API is generally the same for public GitHub, it's just a URL change.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

github_deploy_key

ANSIBLE VERSION
ansible 2.5.3
  config file = None
  configured module search path = [u'/Users/username/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/username/.pyenv/versions/2.7/envs/ansible/lib/python2.7/site-packages/ansible
  executable location = /Users/username/.pyenv/versions/ansible/bin/ansible
  python version = 2.7 (r27:82500, Oct 10 2017, 09:33:49) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.37)]
ADDITIONAL INFORMATION

Admittedly, I made these changes a few months ago and don't remember all the ins and outs. I think some of the edits I made because pylint was giving lots of complaints in Atom. I'm willing to go back and forth, but I think this is an important feature to have on all the GitHub modules.

@ansibot
Copy link
Contributor

ansibot commented May 18, 2018

@dcode this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 feature This issue/PR relates to a feature request. merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels May 18, 2018
@ansibot
Copy link
Contributor

ansibot commented May 18, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/source_control/github_deploy_key.py:0:0: E309 version_added for new option (api_url) should be 2.6. Currently 0.0

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 18, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label May 24, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 1, 2018
@ansibot ansibot added the needs_repo This PR no longer has an associated branch as it was removed by the submitter. label Jul 3, 2018
@webknjaz
Copy link
Member

webknjaz commented Sep 5, 2018

N.B. this PR's fork repository or branch has been deleted by the owner.
If anyone is up to pick up the work they can pull the branch using this guide https://help.github.com/articles/checking-out-pull-requests-locally/#modifying-an-inactive-pull-request-locally and then re-submit the fixed branch as a new PR.
If the author is going to do it themselves, they'll need to make sure to restore the fork and the branch within with the same name.

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed support:community This issue/PR relates to code supported by the Ansible community. labels Sep 21, 2018
@ansibot ansibot added needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 7, 2018
@ansibot ansibot removed the needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) label Nov 9, 2018
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Nov 26, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 15, 2018

@dcode Your branch does not contain a shippable.yml file. Please rebase your branch to trigger running of current tests.

click here for bot help

@ansibot ansibot added the needs_shippable This PR lacks a shippable.yml in its tree. Please rebase your branch to include the latest CI tests. label Dec 15, 2018
@ansibot ansibot added the source_control Source-control category label Feb 18, 2019
@gundalow gundalow added the pr_day Has been reviewed during a PR review Day label Sep 3, 2019
@gundalow
Copy link
Contributor

gundalow commented Sep 3, 2019

@dcode This looks useful, if you could please update DOCUMENTATION as I've put above, we can get this merged. Thank in advance.

@gundalow
Copy link
Contributor

@dcode
Thank you for your PR.
As part of reviewing the backlog of PRs we are looking at PRs older PRs that haven't been updated in a while

Given that:

  • PR has failed CI May 2018
  • This is a feature rather than a bug fix
  • The source branch (in your fork) no longer exists

Therefore I'm going to close this.

If you or anyone else wants to continue with this work then please do feel free to create a fresh PR and @mention the previous reviewers in here.

@gundalow gundalow closed this Sep 19, 2019
@ansible ansible locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.6 This issue/PR affects Ansible v2.6 ci_verified Changes made in this PR are causing tests to fail. feature This issue/PR relates to a feature request. has_issue merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_repo This PR no longer has an associated branch as it was removed by the submitter. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_shippable This PR lacks a shippable.yml in its tree. Please rebase your branch to include the latest CI tests. pr_day Has been reviewed during a PR review Day source_control Source-control category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants