Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

Bot should post a useful comment once it detects a PR with missing repo/branch #1018

Closed
webknjaz opened this issue Sep 5, 2018 · 4 comments
Closed

Bot should post a useful comment once it detects a PR with missing repo/branch #1018

webknjaz opened this issue Sep 5, 2018 · 4 comments
Labels
enhancement
Projects
Bot Work Contributor Experience

Comments

@webknjaz
Copy link
Member

webknjaz commented Sep 5, 2018

I expect that i'd post somethig like ansible/ansible#40411 (comment) if check like #1017 met.
@webknjaz
Copy link
Member Author

webknjaz commented Sep 5, 2018

N.B. It was suggested by @jctanner in Slack that it should also be closed. But I still insist on posting a message along with that.

@jctanner
Copy link
Contributor

jctanner commented Sep 5, 2018

Yep, the closure message can indicate why it was closed.

@jctanner
Copy link
Contributor

jctanner commented Sep 5, 2018

@gundalow thoughts?

@gundalow gundalow added this to Backlog in Bot Work Sep 6, 2018
@gundalow
Copy link
Collaborator

gundalow commented Sep 7, 2018

+1 to closing with message

@webknjaz webknjaz moved this from Backlog to To do in Bot Work Sep 7, 2018
@gundalow gundalow added this to To Triage in Contributor Experience via automation Sep 25, 2018
@gundalow gundalow moved this from To Triage to Next in Contributor Experience Sep 25, 2018
@gundalow gundalow moved this from Next to Medium in Contributor Experience Nov 8, 2018
webknjaz added a commit to webknjaz/ansibullbot that referenced this issue Dec 8, 2018
@webknjaz
Advise users how to proceed with lost PR branch
d00ed0e 
Fixes ansible#1018
@webknjaz webknjaz mentioned this issue Dec 8, 2018
Merged
webknjaz added a commit to webknjaz/ansibullbot that referenced this issue Dec 8, 2018
@webknjaz
Advise users how to proceed with lost PR branch
43467c6 
Fixes ansible#1018
webknjaz added a commit to webknjaz/ansibullbot that referenced this issue Dec 12, 2018
@webknjaz
Advise users how to proceed with lost PR branch
c8db811 
Fixes ansible#1018
Bot Work automation moved this from To do to Done Dec 13, 2018
Contributor Experience automation moved this from Medium to Done Dec 13, 2018
gundalow pushed a commit that referenced this issue Dec 13, 2018
@webknjaz @gundalow
Close missing incoming branch with advice (#1119)
14bc5dc 
* Refactor incoming repo access properties

* Advise users how to proceed with lost PR branch

Fixes #1018

* Fix typo in "with" word in comment template

* Wrap `git push` command as a code block

* Improve wording in the comment's second paragraph

* Refactor template vars generation

* Ensure that PR creation link is urlencoded
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
Bot Work
  
Done
Contributor Experience
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@webknjaz @gundalow @jctanner