Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

Bot should post a useful comment once it detects a PR with missing repo/branch #1018

Closed
webknjaz opened this issue Sep 5, 2018 · 4 comments

Comments

@webknjaz
Copy link
Member

webknjaz commented Sep 5, 2018

I expect that i'd post somethig like ansible/ansible#40411 (comment) if check like #1017 met.

@webknjaz
Copy link
Member Author

webknjaz commented Sep 5, 2018

N.B. It was suggested by @jctanner in Slack that it should also be closed. But I still insist on posting a message along with that.

@jctanner
Copy link
Contributor

jctanner commented Sep 5, 2018

Yep, the closure message can indicate why it was closed.

@jctanner
Copy link
Contributor

jctanner commented Sep 5, 2018

@gundalow thoughts?

@gundalow
Copy link
Collaborator

gundalow commented Sep 7, 2018

+1 to closing with message

webknjaz added a commit to webknjaz/ansibullbot that referenced this issue Dec 8, 2018
webknjaz added a commit to webknjaz/ansibullbot that referenced this issue Dec 8, 2018
webknjaz added a commit to webknjaz/ansibullbot that referenced this issue Dec 12, 2018
gundalow pushed a commit that referenced this issue Dec 13, 2018
* Refactor incoming repo access properties

* Advise users how to proceed with lost PR branch

Fixes #1018

* Fix typo in "with" word in comment template

* Wrap `git push` command as a code block

* Improve wording in the comment's second paragraph

* Refactor template vars generation

* Ensure that PR creation link is urlencoded
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants