New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding module to manage replication instances for AWS Database Migration Service #40567

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@slapula
Contributor

slapula commented May 22, 2018

SUMMARY

This is the next pull request in my attempt to add support for AWS Database Migration Service. This module manages the replication instances in the spirit of ec2_instance. One difference, however, is that I tend to prefer gathering facts through a dedicated _facts module so I've only included instance_arn in what this module returns upon execution. I'm open to adding more to the output though if it's deemed necessary.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

dms_instance

ANSIBLE VERSION
ansible 2.4.1.0
  config file = None
  configured module search path = [u'/Users/asmith/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/asmith/.pyenv/versions/2.7.13/lib/python2.7/site-packages/ansible
  executable location = /Users/asmith/.pyenv/versions/2.7.13/bin/ansible
  python version = 2.7.13 (default, Sep  8 2017, 15:16:38) [GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)]
@mattclay

This comment has been minimized.

Member

mattclay commented Jun 8, 2018

CI failure in integration tests due to a traceback:

Traceback (most recent call last):
  File "/tmp/ansible_pT4odB/ansible_module_dms_instance.py", line 172, in create_instance
    response = client.create_replication_instance(**params)
  File "/usr/local/lib/python2.7/dist-packages/botocore/client.py", line 314, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/usr/local/lib/python2.7/dist-packages/botocore/client.py", line 612, in _make_api_call
    raise error_class(parsed_response, operation_name)
ClientError: An error occurred (AccessDeniedException) when calling the CreateReplicationInstance operation: User: arn:aws:sts::966509639900:assumed-role/ansible-core-ci-test-prod/prod=shippable=ansible=ansible=66749.66 is not authorized to perform: dms:CreateReplicationInstance

This is permissions related. We'll need to see if our CI system can be updated to support this.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jun 8, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_instance.py:0:0: E307 version_added should be 2.7. Currently 2.6

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment