Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding module to manage replication instances for AWS Database Migration Service #40567

Closed
wants to merge 2 commits into from

Conversation

slapula
Copy link
Contributor

@slapula slapula commented May 22, 2018

SUMMARY

This is the next pull request in my attempt to add support for AWS Database Migration Service. This module manages the replication instances in the spirit of ec2_instance. One difference, however, is that I tend to prefer gathering facts through a dedicated _facts module so I've only included instance_arn in what this module returns upon execution. I'm open to adding more to the output though if it's deemed necessary.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

dms_instance

ANSIBLE VERSION
ansible 2.4.1.0
  config file = None
  configured module search path = [u'/Users/asmith/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/asmith/.pyenv/versions/2.7.13/lib/python2.7/site-packages/ansible
  executable location = /Users/asmith/.pyenv/versions/2.7.13/bin/ansible
  python version = 2.7.13 (default, Sep  8 2017, 15:16:38) [GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)]

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 aws cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 22, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label May 24, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 1, 2018
@mattclay
Copy link
Member

mattclay commented Jun 8, 2018

CI failure in integration tests due to a traceback:

Traceback (most recent call last):
  File "/tmp/ansible_pT4odB/ansible_module_dms_instance.py", line 172, in create_instance
    response = client.create_replication_instance(**params)
  File "/usr/local/lib/python2.7/dist-packages/botocore/client.py", line 314, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/usr/local/lib/python2.7/dist-packages/botocore/client.py", line 612, in _make_api_call
    raise error_class(parsed_response, operation_name)
ClientError: An error occurred (AccessDeniedException) when calling the CreateReplicationInstance operation: User: arn:aws:sts::966509639900:assumed-role/ansible-core-ci-test-prod/prod=shippable=ansible=ansible=66749.66 is not authorized to perform: dms:CreateReplicationInstance

This is permissions related. We'll need to see if our CI system can be updated to support this.

@mattclay mattclay added the needs_ci_update This PR is blocked as it requires an update to CI infrastructure before tests can pass in CI. label Jun 8, 2018
@ansibot
Copy link
Contributor

ansibot commented Jun 8, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_instance.py:0:0: E307 version_added should be 2.7. Currently 2.6

click here for bot help

@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Oct 24, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 31, 2020

@ansibot ansibot added collection Related to Ansible Collections work collection:community.aws support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 29, 2020
@Akasurde
Copy link
Member

Hi @slapula, Thank you very much for your interest in Ansible. This plugin/module is no longer maintained in this repository and has been migrated to https://github.com/ansible-collections/community.aws

If you have further questions please stop by IRC or the mailing list:

* IRC: #ansible on irc.freenode.net
* mailing list: https://groups.google.com/forum/#!forum/ansible-project

needs_info

@Akasurde Akasurde closed this Aug 19, 2020
@ansible ansible locked as resolved and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.6 This issue/PR affects Ansible v2.6 aws cloud collection:community.aws collection Related to Ansible Collections work module This issue/PR relates to a module. needs_ci_update This PR is blocked as it requires an update to CI infrastructure before tests can pass in CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants