Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New facts module: Memset server products #42386

Merged
merged 4 commits into from
Oct 29, 2018
Merged

New facts module: Memset server products #42386

merged 4 commits into from
Oct 29, 2018

Conversation

glitchcrab
Copy link
Contributor

SUMMARY

This PR provides a facts module for dedicated servers and VPSes (grouped as 'servers') hosted by Memset.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

memset_server_facts

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 5, 2018
@glitchcrab glitchcrab changed the title initial commit of facts module for Memset VPS/dedicated server products New facts module: Memset server products Jul 5, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jul 5, 2018
@ansibot ansibot added the test This PR relates to tests. label Jul 6, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 14, 2018
@ghost
Copy link

ghost commented Jul 25, 2018

Tested it all works fine for me.

@duncan9562
Copy link

Tested, all works perfectly!

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 29, 2018
@gundalow gundalow merged commit 893c0db into ansible:devel Oct 29, 2018
@gundalow
Copy link
Contributor

@analbeard Thank you for the PR
@timethrow @duncan9562 Thank you for the reviews. Knowing the people have actually used the PR is the best type of feedback.

Merged into devel for release in Ansible 2.8

@glitchcrab glitchcrab deleted the memset_server_facts branch October 29, 2018 13:15
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@analbeard @Tomorrow9
New facts module: Memset server products (ansible#42386)
9ecb1d9 
* initial commit of facts module for Memset VPS/dedicated server products

* add missing brace

* add integration tests (disabled until we have a mock API to test against)

* bump ansible release version to 2.8
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@glitchcrab @duncan9562 @gundalow @samdoran @ansibot @analbeard