Remove use of simplejson throughout code base #43548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
jborean93
removed
the
needs_triage
ansibot
added
core_review
abadger
reviewed
Aug 6, 2018
| # Version 1.5 released 2007-01-18 does not have the encoding parameter which we need | ||
| print('\n{"msg": "Error: Ansible requires the stdlib json or simplejson >= 1.6. Neither was found!", "failed": true}') | ||
| print('\n{"msg": "Error: ansible requires the stdlib json and was not found!", "failed": true}') | ||
| sys.exit(1) | ||
|
|
There was a problem hiding this comment.
I'm not entirely sure what we want to do with these... The libs which override json are still present on pypi. But I bet nowadays they will break more than ansible so we don't have to worry about them. On the other hand, I would have thought that when I had to add the code that handled that.
There was a problem hiding this comment.
I've added back in the python-json checks.
ansibot
added
needs_revision
|
This looks good +1 |
ansibot
added
shipit
|
bot_skip For > 50 files |
|
Build succeeded (third-party-check pipeline).
|
nitzmahone
approved these changes
Aug 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Remove use of simplejson throughout code base. Fixes #42761
ISSUE TYPE
COMPONENT NAME
many
ANSIBLE VERSION
ADDITIONAL INFORMATION