Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make domain an optional parameter #44385

Closed
wants to merge 1 commit into from
Closed

Make domain an optional parameter #44385

wants to merge 1 commit into from

Conversation

dhozac
Copy link
Contributor

@dhozac dhozac commented Aug 20, 2018

If not specified, find the domain which the current record ends with.

SUMMARY

The module can easily figure out the domain name, and not specifying it makes automation easier as it is one less value to keep track of for every record.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

dnsmadeeasy

ANSIBLE VERSION
ansible 2.6.2
  config file = None
  configured module search path = [u'/home/daniel/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/daniel/.local/lib/python2.7/site-packages/ansible
  executable location = /home/daniel/.local/bin/ansible
  python version = 2.7.13 (default, Nov 24 2017, 17:33:09) [GCC 6.3.0 20170516]

@dhozac
Make domain an optional parameter
a8b8e8a 
If not specified, find the domain which the current record ends with.
@ansibot
Copy link
Contributor

ansibot commented Aug 20, 2018

cc @briceburg
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. net_tools Net-tools category support:community This issue/PR relates to code supported by the Ansible community. labels Aug 20, 2018
@webknjaz webknjaz requested a review from sivel August 21, 2018 15:16
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Aug 21, 2018
webknjaz
webknjaz reviewed Aug 21, 2018
View reviewed changes
lib/ansible/modules/net_tools/dnsmadeeasy.py
# Lookup the domain if none was passed
elif self.domain is None:
self._instMap('domain')
for id, domain in self.domain_map.items():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use id_ instead of masking builtin

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 29, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 6, 2018
@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed support:community This issue/PR relates to code supported by the Ansible community. labels Sep 14, 2018
@ansibot ansibot added needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 8, 2018
@ansibot ansibot removed the needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) label Nov 9, 2018
@ansibot ansibot added collection Related to Ansible Collections work collection:community.general needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@ansibot
Copy link
Contributor

ansibot commented Aug 17, 2020

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md

@ansibot ansibot closed this Aug 17, 2020
@ansible ansible locked and limited conversation to collaborators Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@webknjaz webknjaz webknjaz left review comments

@sivel sivel Awaiting requested review from sivel

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bot_closed collection:community.general collection Related to Ansible Collections work feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. net_tools Net-tools category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhozac @ansibot @webknjaz