Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ios_user issues #44904

Merged
merged 2 commits into from Aug 31, 2018
Merged

Fix ios_user issues #44904

merged 2 commits into from Aug 31, 2018

Conversation

NilashishC
Copy link
Contributor

@NilashishC NilashishC commented Aug 30, 2018 •
edited

SUMMARY

Fixes the following:

  • Fixes IOS_USER: unable to delete admin account #44075 [ Unable to delete admin account ]
  • The module was not able to detect users configured with sshkey. Fixed regex to mitigate the issue.
  • Rearranged code to eliminate duplicate and extra commands that were being executed
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_user.py

ANSIBLE VERSION
devel

@ansibot
Copy link
Contributor

ansibot commented Aug 30, 2018

cc @rcarrillocruz @trishnaguha
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 30, 2018

Hi @NilashishC,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 30, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 30, 2018

cc @Qalthos @ganeshrn @gdpak @justjais
click here for bot help

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 30, 2018
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Aug 31, 2018
@NilashishC NilashishC merged commit 0f268e7 into ansible:devel Aug 31, 2018
@NilashishC NilashishC deleted the fix_ios_user branch August 31, 2018 05:38
mattclay pushed a commit that referenced this pull request Sep 4, 2018
@NilashishC @mattclay
Fix ios_user issue CP in 2.6 (#45175)
0c367e7 
* Fix ios_user issues (#44904)

* Fix ios_user issues

* Modify regex and fix unittests

(cherry picked from commit 0f268e7)

* Added changelog
nitzmahone pushed a commit that referenced this pull request Sep 5, 2018
@NilashishC @nitzmahone
Fix ios_user issue CP in 2.5 (#45180)
7113e50 
* Fix ios_user issues (#44904)

* Fix ios_user issues

* Modify regex and fix unittests

(cherry picked from commit 0f268e7)

* Added changelog
linnil1
linnil1 reviewed Feb 23, 2019
View reviewed changes
lib/ansible/modules/network/ios/ios_user.py
if have['sshkey']:
add_ssh(commands, want)
else:
commands.append(user_del_cmd(want['name']))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is in else condition.
If this user have sshkey in settings, it will remove user's sshkey at first time, and remove user at second time?

@dagwieers dagwieers added ios Cisco IOS community cisco Cisco technologies labels Feb 27, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@linnil1 linnil1 linnil1 left review comments

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community module This issue/PR relates to a module. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IOS_USER: unable to delete admin account
5 participants
@NilashishC @ansibot @trishnaguha @linnil1 @dagwieers