[aws] s3_lifecycle fix backwards compatibility without providing prefix #45318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more parameter validation than boto (ansible#45308) Use .get() instead of assuming a rule has a Transitions or Filter key (both of which are optional) (cherry picked from commit 8b34161)
s-hertel
approved these changes
Sep 6, 2018
This was referenced Sep 6, 2018
|
Hi @ryansb, Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for aws. |
ansibot
added
affects_2.7
|
Merged for the 2.7.0rc1 release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Because boto3 does more parameter validation than boto, use .get() instead of assuming a rule has a Transitions or Filter key (both of which are optional)
Fixes #44557
ISSUE TYPE
COMPONENT NAME
ANSIBLE VERSION
ADDITIONAL INFORMATION