Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add win_iis_webhandler #45998

Closed
wants to merge 9 commits into from
Closed

Add win_iis_webhandler #45998

wants to merge 9 commits into from

Conversation

arestarh
Copy link

SUMMARY

Adds support for managing HTTP handlers in IIS for a Windows host.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

win_iis_webhandler

ANSIBLE VERSION
ansible 2.6.4
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/andriibi/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Sep 15 2016, 22:37:39) [GCC 4.8.5 20150623 (Red Hat 4.8.5-4)]
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community labels Sep 21, 2018
@ansibot

This comment has been minimized.

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 21, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 21, 2018

@ansibot ansibot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Sep 21, 2018
@ansibot

This comment has been minimized.

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. and removed ci_verified Changes made in this PR are causing tests to fail. labels Sep 21, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 21, 2018

@Daniel-Sanchez-Fabregas @LiranNis @SamLiu79 @timothyvandenbrande @andrewsaraceni @ar7z1 @blakfeld @brianlloyd @cchurch @chrishoffman @crossan007 @daBONDi @elventear @erwanquelin @henrikwallstrom @if-meaton @joshludwig @marqelme @nwchandler @nwsparks @petemounce @ptemplier @richardcs @riponbanik @schwartzmx @smadam813 @themiwi @tksarah

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 21, 2018
@webknjaz

This comment has been minimized.

@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Sep 25, 2018
@equelin

This comment has been minimized.

@webknjaz

This comment has been minimized.

@equelin

This comment has been minimized.

@webknjaz

This comment has been minimized.

@webknjaz

This comment has been minimized.

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Nov 3, 2018
Fixes for module itself according to jborean93 suggestions:
- Last try\catch block is not needed.
- Some parameter names were changed to be more snake_case.
Fixes for module documentation according to jborean93 suggestions:
- Some parameter names were changed to be more snake_case.
@ansibot ansibot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Nov 3, 2018
@webknjaz webknjaz dismissed jborean93’s stale review November 3, 2018 23:04

Needs a new review

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 3, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 11, 2018
@dagwieers
Copy link
Contributor

dagwieers commented Jan 23, 2019

During the next Windows WG meeting on 2019-01-29 we will review and decide on the inclusion of this module in Ansible v2.8. Your presence in the meeting could be helpful.

If there's anything you wanted to improve/fix, please do so before the meeting.

@nitzmahone
Copy link
Member

After some discussion at the Windows Working Group module review, we're a little nervous to take on more IIS modules into the core distribution right now, especially given the state of the other IIS modules we already have. This would be a good candidate for the new collections feature that's coming in Ansible 2.8, which would allow these modules to be hosted on galaxy.ansible.com and easily installed/upated by users on their Ansible controller.

@arestarh
Copy link
Author

arestarh commented Feb 2, 2019

After some discussion at the Windows Working Group module review, we're a little nervous to take on more IIS modules into the core distribution right now, especially given the state of the other IIS modules we already have. This would be a good candidate for the new collections feature that's coming in Ansible 2.8, which would allow these modules to be hosted on galaxy.ansible.com and easily installed/upated by users on their Ansible controller.

Thanks, guys, for review and feedback.
I thought about it and I agree with you. Besides that, unfortunately, I don't have much time to fully support module.

@ShachafGoldstein
Copy link
Contributor

@arestarh - can you close the PR if it is no longer required?

@arestarh
Copy link
Author

@nitzmahone @jborean93
Guys, as Mat already mentioned with recently released ansible version 2.8 new feature called Collections has arrived.

I have several questions and maybe you can give me some suggestions what to do.

  1. In general, what should I do with module and with PR in particular ?
  2. I've tried to look for documentation regarding Collections on https://docs.ansible.com/ansible/latest/, but didn't find such. Could you please give me correct link ?

Thanks.

@webknjaz
Copy link
Member

webknjaz commented May 22, 2019

Hi Andrew, it's not yet well-documented but you may take a look at the example (incomplete) dir structure https://github.com/bcoca/collection (plugins/modules is a place putting modules in such dir layout) and https://github.com/ansible/mazer.
Alternatively, wait for the docs and subsequent improvements.

@jborean93
Copy link
Contributor

Collections are now more of a first class citizen with Ansible and we have better documentation around it. You can follow the user guide which goes into detail on how to install and use collection inside Ansible itself.

The dev guide goes through the process of how to create your own collection as well as publish it to Ansible Galaxy.

@jborean93 jborean93 closed this Nov 12, 2019
@ansible ansible locked and limited conversation to collaborators Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. has_issue module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants