Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid spurious warnings on unique filter #46231

Merged
merged 1 commit into from
Nov 14, 2018
Merged

avoid spurious warnings on unique filter #46231

merged 1 commit into from
Nov 14, 2018

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Sep 27, 2018

fixes #46189

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

filters/unique

ANSIBLE VERSION
2.8

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 27, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Sep 27, 2018
@bcoca bcoca requested a review from sivel September 27, 2018 20:11
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 27, 2018
@mattclay mattclay added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Oct 1, 2018
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 9, 2018
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 10, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 25, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 7, 2018
@gundalow gundalow changed the title avoid spurious warnigns on unique filter avoid spurious warnings on unique filter Nov 7, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. community_review In order to be merged, this PR must follow the community review workflow. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 7, 2018
@bcoca bcoca merged commit 24593f2 into ansible:devel Nov 14, 2018
@bcoca bcoca deleted the fix_j2_unique branch November 14, 2018 14:33
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Xaroth Xaroth Xaroth approved these changes

@gundalow gundalow gundalow approved these changes

@sivel sivel Awaiting requested review from sivel

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WARNING]: Falling back to Ansible unique filter as Jinaj2 one failed: unhashable type: 'list'
5 participants
@bcoca @Xaroth @gundalow @mattclay @ansibot