Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nxos modules idempotence issue #46437

Merged
merged 4 commits into from
Nov 29, 2018
Merged

Fix nxos modules idempotence issue #46437

merged 4 commits into from
Nov 29, 2018

Conversation

OlivierB
Copy link
Contributor

@OlivierB OlivierB commented Oct 3, 2018

SUMMARY

Fix 4 issues where new Ansible execution imply a change=True status.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_interface
nxos_linkagg

ANSIBLE VERSION
devel

@OlivierB
nxos_interface vlan and port-channel idempotence fix for mtu
8c71512 
* Fix MTU reconfiguration at each execution
@OlivierB
nxos_interface port-channel idempotence fix for mode (ansible#44248)
abc3b22 
* Fix trunk mode idempotence for port-channel
* Gather ethernet and port-channel code for mode management
@OlivierB
nxos_linkagg port-channel idempotence fix for channel-group's mode
a9ef8ef 
The regex to retrieve channel-group's mode is not enough accurate.
Therefore, the swhitchport mode  was matched instead of the
channel-group's mode.

* This fix add accuracy to match the right configuration command
@OlivierB
Add support for switchport mode dot1q-tunnel in nxos_interface
fec0827 
* Fix layer reconfiguration at each execution
@ansibot
Copy link
Contributor

ansibot commented Oct 3, 2018

cc @mikewiebe @rahushen @rcarrillocruz @trishnaguha @tstoner
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 3, 2018

Hi @OlivierB,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. labels Oct 3, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Oct 4, 2018
@trishnaguha trishnaguha self-assigned this Oct 8, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 16, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 25, 2018
@trishnaguha
Copy link
Member

Thanks for the PR @OlivierB

@trishnaguha trishnaguha merged commit c51407c into ansible:devel Nov 29, 2018
@trishnaguha trishnaguha moved this from In Review to Need CP to into 2.7 in zzz NOT USED: Networking Bugs Nov 29, 2018
@trishnaguha trishnaguha moved this from Need CP to into 2.7 to Need CP into 2.6 in zzz NOT USED: Networking Bugs Nov 29, 2018
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Nov 29, 2018
@OlivierB @trishnaguha
Fix nxos modules idempotence issue (ansible#46437)
2209913 
* nxos_interface vlan and port-channel idempotence fix for mtu

* Fix MTU reconfiguration at each execution

* nxos_interface port-channel idempotence fix for mode (ansible#44248)

* Fix trunk mode idempotence for port-channel
* Gather ethernet and port-channel code for mode management

* nxos_linkagg port-channel idempotence fix for channel-group's mode

The regex to retrieve channel-group's mode is not enough accurate.
Therefore, the swhitchport mode  was matched instead of the
channel-group's mode.

* This fix add accuracy to match the right configuration command

* Add support for switchport mode dot1q-tunnel in nxos_interface

* Fix layer reconfiguration at each execution

(cherry picked from commit c51407c)
@trishnaguha trishnaguha moved this from Need CP into 2.6 to Done in zzz NOT USED: Networking Bugs Nov 29, 2018
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Nov 29, 2018
@OlivierB @trishnaguha
Fix nxos modules idempotence issue (ansible#46437)
bf4f78c 
* nxos_interface vlan and port-channel idempotence fix for mtu

* Fix MTU reconfiguration at each execution

* nxos_interface port-channel idempotence fix for mode (ansible#44248)

* Fix trunk mode idempotence for port-channel
* Gather ethernet and port-channel code for mode management

* nxos_linkagg port-channel idempotence fix for channel-group's mode

The regex to retrieve channel-group's mode is not enough accurate.
Therefore, the swhitchport mode  was matched instead of the
channel-group's mode.

* This fix add accuracy to match the right configuration command

* Add support for switchport mode dot1q-tunnel in nxos_interface

* Fix layer reconfiguration at each execution

(cherry picked from commit c51407c)
@OlivierB OlivierB deleted the alpha_pull_request branch November 29, 2018 10:06
abadger pushed a commit that referenced this pull request Dec 4, 2018
@OlivierB @abadger
Fix nxos modules idempotence issue (#46437)
d041673 
* nxos_interface vlan and port-channel idempotence fix for mtu

* Fix MTU reconfiguration at each execution

* nxos_interface port-channel idempotence fix for mode (#44248)

* Fix trunk mode idempotence for port-channel
* Gather ethernet and port-channel code for mode management

* nxos_linkagg port-channel idempotence fix for channel-group's mode

The regex to retrieve channel-group's mode is not enough accurate.
Therefore, the swhitchport mode  was matched instead of the
channel-group's mode.

* This fix add accuracy to match the right configuration command

* Add support for switchport mode dot1q-tunnel in nxos_interface

* Fix layer reconfiguration at each execution

(cherry picked from commit c51407c)
mattclay pushed a commit that referenced this pull request Dec 10, 2018
@OlivierB @mattclay
Fix nxos modules idempotence issue (#46437)
64b68ef 
* nxos_interface vlan and port-channel idempotence fix for mtu

* Fix MTU reconfiguration at each execution

* nxos_interface port-channel idempotence fix for mode (#44248)

* Fix trunk mode idempotence for port-channel
* Gather ethernet and port-channel code for mode management

* nxos_linkagg port-channel idempotence fix for channel-group's mode

The regex to retrieve channel-group's mode is not enough accurate.
Therefore, the swhitchport mode  was matched instead of the
channel-group's mode.

* This fix add accuracy to match the right configuration command

* Add support for switchport mode dot1q-tunnel in nxos_interface

* Fix layer reconfiguration at each execution

(cherry picked from commit c51407c)
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category new_contributor This PR is the first contribution by a new community member. nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
No open projects
zzz NOT USED: Networking Bugs
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@OlivierB @ansibot @trishnaguha @dagwieers @jborean93