Replace obsolete with_items by loop in error message

[bmillemathias]

SUMMARY

Replace example provided when error YAML_COMMON_UNQUOTED_VARIABLE_ERROR is raised with loop instead of with_items

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

Error Message

ANSIBLE VERSION

can be any starting with ansible 2.5

[ansibot]

Hi @bmillemathias, thank you for submitting this pull-request!

click here for bot help

[beeankha]

I tested the usage of loop using a playbook that originally had with_items. Snippet of the playbook is below:

- name: Install npm modules required by our app
  npm:
    name: "{{item}}"
    global: yes
    state: present
  loop: "{{node_npm_modules}}"

The items being looped through:

---
node_npm_modules:
  - forever
  - async
  - request

Output from the run is below:

bhenderson$ ansible-playbook -i inventory nodejsrole.yml

PLAY [web2] ********************************************************************

TASK [Gathering Facts] *********************************************************
ok: [192.168.60.5]

TASK [Install Remi repo.] ******************************************************
changed: [192.168.60.5]

TASK [nodejs : Install Node.js and npm.] ***************************************
changed: [192.168.60.5]

TASK [nodejs : Install npm modules required by our app] ************************
changed: [192.168.60.5] => (item=forever)
changed: [192.168.60.5] => (item=async)
changed: [192.168.60.5] => (item=request)

[other tasks cut out for output brevity]

PLAY RECAP *********************************************************************
192.168.60.5               : ok=12   changed=8    unreachable=0    failed=0

[acozine]

Thanks @beeankha for testing! Thanks @bmillemathias for updating and modernizing this error message.