xfconf: "get": don't set changed flag, don't require value #48331
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the need to pass a value when state equals "get" (it can still be passed -- it'll just be ignored, same as before), and makes sure that "get" always leaves the changed flag at false. Below is a short ansible playbook for an XFCE4 machine that demonstrates both these behaviors and runs cleanly with the updated xfconf.py. (Also, thank you very much to @jbenden for creating this module!) --- - hosts: 127.0.0.1 connection: local tasks: - name: Fetch the theme xfconf: channel: xfwm4 property: "/general/theme" state: get value: '' register: theme - debug: msg: "The theme is {{ theme.ansible_facts.xfconf.new_value }}" - name: Fetch the theme in a way that will blow up xfconf: channel: xfwm4 property: "/general/theme" state: get
|
Hi @mattiklock, thank you for submitting this pull-request! |
|
@mattiklock This PR contains |
ansibot
added
affects_2.8
|
The test The test |
pylint caught whitespace on 184
ansibot
removed
the
ci_verified
jborean93
removed
the
needs_triage
jborean93
changed the title
ansibot
added
stale_ci
ansibot
removed
the
stale_ci
ansibot
added
the
stale_ci
ansibot
removed
the
stale_ci
resmo
reviewed
Dec 19, 2018
| if value.lower() == "true": | ||
| value = "true" | ||
| elif value.lower() == "false": | ||
| value = "false" |
There was a problem hiding this comment.
not a blocker, but a simpler check would be
if value.lower() in ('true', 'false'):
value = value.lower()
ansibot
added
the
stale_ci
|
Any chance this gets merged in the near future? It is quite a small change (one of the zillions you have, I know). Just a friendly check. |
|
This PR will be superseded by #62578 |
ansibot
added
the
needs_rebase
ansibot
added
collection
|
Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.
For further information, please see: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This change removes the need to pass a value when state equals "get" (it can still be passed -- it'll just be ignored, same as before), and makes sure that "get" always leaves the changed flag at false.
Below is a short ansible playbook for an XFCE4 machine that demonstrates both these behaviors and runs cleanly with the updated xfconf.py.
(Also, thank you very much to jbenden for creating this module!)
ISSUE TYPE
COMPONENT NAME
xfconf
ANSIBLE VERSION