Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfconf: "get": don't set changed flag, don't require value #48331

Closed
wants to merge 2 commits into from
Closed

xfconf: "get": don't set changed flag, don't require value #48331

wants to merge 2 commits into from

Commits on Nov 8, 2018

  1. "get": don't set changed flag, don't require value 

    This change removes the need to pass a value when state equals "get" (it can still be passed -- it'll just be ignored, same as before), and makes sure that "get" always leaves the changed flag at false.

Below is a short ansible playbook for an XFCE4 machine that demonstrates both these behaviors and runs cleanly with the updated xfconf.py.

(Also, thank you very much to @jbenden for creating this module!)

---
- hosts: 127.0.0.1
  connection: local

  tasks:
    - name: Fetch the theme
      xfconf:
        channel: xfwm4
        property: "/general/theme"
        state: get
        value: ''
      register: theme

    - debug:
        msg: "The theme is {{ theme.ansible_facts.xfconf.new_value }}"
        
    - name: Fetch the theme in a way that will blow up
      xfconf:
        channel: xfwm4
        property: "/general/theme"
        state: get
    @mattiklock
    mattiklock committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    70f25ac View commit details
    Browse the repository at this point in the history

  2. fix trailing whitespace 

    pylint caught whitespace on 184
    @mattiklock
    mattiklock committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    2c9bd07 View commit details
    Browse the repository at this point in the history