ovirt hosts facts add cluster version filtration #48664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mnecas, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
| ) | ||
| if(module.params.get('cluster_version')): |
There was a problem hiding this comment.
please remove () around if
| @@ -83,7 +100,10 @@ def main(): | |||
| hosts = hosts_service.list( | |||
| search=module.params['pattern'], | |||
| all_content=module.params['all_content'], | |||
| follow='cluster' | |||
There was a problem hiding this comment.
please add , at the end
| filtered_hosts = [] | ||
| for host in hosts: | ||
| cluster = host.cluster | ||
| if(str(cluster.version.major) + '.' + str(cluster.version.minor) == module.params.get('cluster_version')): |
There was a problem hiding this comment.
please remove () around if
| def main(): | ||
| argument_spec = ovirt_facts_full_argument_spec( | ||
| pattern=dict(default='', required=False), | ||
| all_content=dict(default=False, type='bool'), | ||
| cluster_version=dict(default=None, type='str'), |
There was a problem hiding this comment.
Add that param also to documentation
There was a problem hiding this comment.
I would make it a list so user can pass more versions
|
The test |
ansibot
added
ci_verified
ansibot
added
community_review
ansibot
added
the
stale_ci
| # All hosts with cluster version 4.2: | ||
| - ovirt_host_facts: | ||
| pattern: name=host* | ||
| cluster_version: |
There was a problem hiding this comment.
Hmm, better would be a string.
| @@ -33,6 +33,12 @@ | |||
| default: False | |||
| version_added: "2.7" | |||
| type: bool | |||
| cluster_version: | |||
| description: | |||
| - "Filters all your hosts which you got and returns only those with correct version of cluster." | |||
There was a problem hiding this comment.
Filter the hosts based on the cluster version.
| cluster_version: | ||
| description: | ||
| - "Filters all your hosts which you got and returns only those with correct version of cluster." | ||
| type: dict |
ansibot
removed
the
stale_ci
|
shipit |
ansibot
added
automerge
knumskull
pushed a commit
to knumskull/ansible
that referenced
this pull request
Jan 21, 2019
* ovirt hosts facts add cluster version filtration * update filtering of ovirt hosts and input of cluster version * ovirt host facts change compat version to string
dagwieers
added
ovirt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Now you can filter ovirt_hosts_facts with cluster version
Fixes #38871
ISSUE TYPE
COMPONENT NAME
ovirt
ADDITIONAL INFORMATION