Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ec2_scaling_policy to boto3 #49250

Closed
wants to merge 2 commits into from
Closed

Upgrade ec2_scaling_policy to boto3 #49250

wants to merge 2 commits into from

Conversation

pierreant-p
Copy link

SUMMARY

This PR update the ec2_scaling_policy module to boto3 and wraps the calls to the AWS API with the AWSRetry decorator.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_scaling_policy

@ansibot
Copy link
Contributor

ansibot commented Nov 28, 2018

Hi @pierreant-p, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 28, 2018

@pierreant-p, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Nov 28, 2018
@gundalow gundalow changed the title Upgrade ec2 scaling policy to boto3 Upgrade ec2_scaling_policy to boto3 Dec 3, 2018
@gundalow
Copy link
Contributor

gundalow commented Dec 4, 2018

Could you please add a changelog for this https://docs.ansible.com/ansible/devel/community/development_process.html#changelogs

@gundalow
Copy link
Contributor

gundalow commented Dec 4, 2018

@pierreant-p Thank you for this PR.
We don't appear to have any integration tests in test/integration/targets/ for this module. I don't know if they've need special permissions.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Dec 4, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 12, 2018

cc @Zeekin
click here for bot help

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 12, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 31, 2020

cc @jillr @s-hertel @tremble
click here for bot help

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 27, 2020
@ansibot ansibot added collection Related to Ansible Collections work collection:community.aws needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2020

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md

@ansibot ansibot closed this Aug 16, 2020
@ansible ansible locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws bot_closed bug This issue/PR relates to a bug. cloud collection:community.aws collection Related to Ansible Collections work module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pierreant-p @ansibot @gundalow