Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly detect pkg_mgr on fedora/rhel/centos rpm-ostree installed #49256

Merged
merged 2 commits into from
Feb 7, 2019
Merged

correctly detect pkg_mgr on fedora/rhel/centos rpm-ostree installed #49256

merged 2 commits into from
Feb 7, 2019

Conversation

maxamillion
Copy link
Contributor

Signed-off-by: Adam Miller admiller@redhat.com

SUMMARY

Check the path /run/ostree-booted which I'm told by upstream that it
will always be present when a host system is Fedora/RHEL/CentOS
Atomic/CoreOS vs "traditional" distro instance to detect the
non-traditional instance and ensure pkg_mgr selection is correct

Fixes #49184

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

setup

@maxamillion
correctly detect pkg_mgr on fedora/rhel/centos rpm-ostree installed
45bea54 
Check the path /run/ostree-booted which I'm told by upstream that it
will always be present when a host system is Fedora/RHEL/CentOS
Atomic/CoreOS vs "traditional" distro instance to detect the
non-traditional instance and ensure pkg_mgr selection is correct

Fixes ansible#49184

Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion maxamillion added affects_2.7 This issue/PR affects Ansible v2.7 affects_2.8 This issue/PR affects Ansible v2.8 labels Nov 28, 2018
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 28, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 7, 2018
dagwieers
dagwieers previously requested changes Jan 29, 2019
View reviewed changes
lib/ansible/module_utils/facts/system/pkg_mgr.py Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 29, 2019
@maxamillion
remove unnecessary else statement
4cd1c7c 
Signed-off-by: Adam Miller <admiller@redhat.com>
@dagwieers
Copy link
Contributor

How does this related to: #33721 ?

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 29, 2019
@maxamillion
Copy link
Contributor Author

@dagwieers because /usr/bin/rpm-ostree can exist on a non-Atomic Fedora/RHEL/CentOS install, it's not directly related. The problem this PR is trying to fix is in the event you have a non-Atomic install that someone decided to also install rpm-ostree onto, we want to ensure the correct default package manager is selected.

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Feb 7, 2019
@samdoran
Copy link
Contributor

samdoran commented Feb 7, 2019

rebuild_merge

@samdoran samdoran dismissed dagwieers’s stale review February 7, 2019 20:16

Requested changes were made

@samdoran samdoran merged commit 9bb05b7 into ansible:devel Feb 7, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers left review comments

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkg_mgr try use rpm-ostree on non atomic host when it installed
4 participants
@maxamillion @ansibot @dagwieers @samdoran