Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetApp ONTAP module for manage ipspaces #49821

Merged
merged 9 commits into from
May 10, 2019
Merged

NetApp ONTAP module for manage ipspaces #49821

merged 9 commits into from
May 10, 2019

Conversation

vicmunoz
Copy link
Contributor

SUMMARY

New module: na_ontap_ipspace (creation / deletion / rename of IPspaces)

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

na_ontap_ipspace

@ansibot
Copy link
Contributor

ansibot commented Dec 12, 2018

cc @amit0701 @carchi8py @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. labels Dec 12, 2018
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Dec 12, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Dec 12, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 12, 2018

The test ansible-test sanity --test pep8 [explain] failed with 19 errors:

lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:13:7: E126 continuation line over-indented for hanging indent
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:89:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:96:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:111:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:124:21: E126 continuation line over-indented for hanging indent
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:130:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:138:29: E126 continuation line over-indented for hanging indent
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:154:25: E127 continuation line over-indented for visual indent
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:167:17: E126 continuation line over-indented for hanging indent
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:173:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:184:21: E126 continuation line over-indented for hanging indent
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:188:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:191:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:192:37: E126 continuation line over-indented for hanging indent
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:202:21: E126 continuation line over-indented for hanging indent
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:204:21: E128 continuation line under-indented for visual indent
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:210:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:211:37: E126 continuation line over-indented for hanging indent
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:225:33: E126 continuation line over-indented for hanging indent

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:52:25: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:52:25: error EXAMPLES: syntax error: mapping values are not allowed here

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Dec 12, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 12, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:52:25: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:52:25: error EXAMPLES: syntax error: mapping values are not allowed here

click here for bot help

@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Dec 12, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 12, 2018

@amit0701 @carchi8py @dprts @hulquest @lmprice @lonico @ndswartz @schmots1 @timuster

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 12, 2018
lonico
lonico approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

It would be nice if you could add a Unit Test.
There is an example in
#49784

But this is only a suggestion.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Dec 14, 2018
lonico
lonico approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

carchi8py
carchi8py approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@carchi8py carchi8py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shipit

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 21, 2019
@vicmunoz vicmunoz closed this Mar 25, 2019
@vicmunoz vicmunoz reopened this Mar 25, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 25, 2019
lonico
lonico approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 2, 2019
@vicmunoz vicmunoz closed this Apr 15, 2019
@vicmunoz vicmunoz reopened this Apr 15, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 15, 2019
lonico
lonico approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

The bot failed with:
lib/ansible/modules/storage/netapp/na_ontap_ipspace.py:0:0: E307 version_added should be '2.9'. Currently '2.8'

But in my opinion, this should go into 2.8. This PR has been opened for a very long time.
Why does it take so long to get any feedback from Red Hat?

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Apr 17, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 25, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 7, 2019
lonico
lonico approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

thedoubl3j
thedoubl3j reviewed May 10, 2019
View reviewed changes
Copy link
Member

@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for adding in the tests.

@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label May 10, 2019
@thedoubl3j thedoubl3j merged commit ecdb616 into ansible:devel May 10, 2019
@vicmunoz vicmunoz deleted the ontap_module_ipspace branch May 13, 2019 08:00
ndclt pushed a commit to ndclt/ansible that referenced this pull request Jun 13, 2019
@ndclt
NetApp ONTAP module for manage ipspaces (ansible#49821)
d88ee7a 
* NetApp ONTAP module for manage ipspaces

* fixes for ci_cd and code layout

* indentation fixes

* code style fixes

* fixing yamllint issue

* unit test for module na_ontap_ipspace

* fixing sanity tests

* change pytest.skip to pytest.mark.skip

* adding ansible version to 2.9
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thedoubl3j thedoubl3j thedoubl3j left review comments

@carchi8py carchi8py carchi8py approved these changes

@lonico lonico lonico approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. netapp new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vicmunoz @ansibot @carchi8py @lonico @thedoubl3j @mattclay