Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-2.7] [docker_container] Fixes idempotency checks for network_mode & Docker common consolidation #49838

Merged
merged 2 commits into from Jan 7, 2019
Merged

[stable-2.7] [docker_container] Fixes idempotency checks for network_mode & Docker common consolidation #49838

merged 2 commits into from Jan 7, 2019

Conversation

DBendit
Copy link
Contributor

@DBendit DBendit commented Dec 12, 2018

SUMMARY

Backport of #49707 and #49797 to 2.7.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_common
docker_container
docker_network
docker_swarm

ADDITIONAL INFORMATION

N/A

@ansibot
Copy link
Contributor

ansibot commented Dec 12, 2018

cc @akshay196 @chouseknecht @cove @danihodovic @dariko @dusdanig @felixfontein @joshuaconner @jwitko @kassiansun @keitwb @olsaki @softzilla @tbouvet @zfil
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud docker module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Dec 12, 2018
@DBendit
Docker common consolidation (#49707)
0bb66be 
* [docker] Consolidating Python Boolean conversion for Docker API (#49563)

* [docker] Consolidating docker option min version checks (#49564)

* [docker] Moving option min version checks out of docker_swarm (#49564)

Also renaming Boolean cleanup function and fixing docker_container minimum
version check for network interfaces.

* Cleanup from PR feedback
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 12, 2018
felixfontein
felixfontein approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Dec 13, 2018
@abadger abadger merged commit a11e0c1 into ansible:stable-2.7 Jan 7, 2019
@abadger
Copy link
Contributor

abadger commented Jan 7, 2019

Merged for the 2.7.6 release.

@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud docker module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DBendit @ansibot @abadger @felixfontein