Pluribus Networks pn_dscp_map_pri_map module with Unit tests #50142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rajaspachipulusu17, just so you are aware we have a dedicated Working Group for network. |
ansibot
added
affects_2.8
|
CI failure in unit tests: https://app.shippable.com/github/ansible/ansible/runs/99187/9/tests |
mattclay
added
the
ci_verified
mattclay
reviewed
Dec 19, 2018
| import json | ||
|
|
||
| from units.compat.mock import patch | ||
| from ansible.modules.network.netvisor import pn_dhcp_map_pri_map |
There was a problem hiding this comment.
Typo, this looks like it should be pn_dscp_map_pri_map here and in several places below.
ansibot
removed
the
needs_triage
ansibot
added
core_review
|
@Akasurde can you merge this? Thanks, |
Akasurde
requested changes
Dec 24, 2018
| type: str | ||
| state: | ||
| description: | ||
| - State the action to perform. Use 'update' to modify |
There was a problem hiding this comment.
Suggested change
| - State the action to perform. Use 'update' to modify | |
| - State the action to perform. Use C(update) to modify |
There was a problem hiding this comment.
Apply this to rest of modules too.
There was a problem hiding this comment.
I have somehow missed it. I will apply to future modules.
Thanks,
Rajas
ansibot
added
needs_revision
|
Can you merge now @Akasurde ? |
Akasurde
requested changes
Dec 24, 2018
| if state == 'update': | ||
| self.run_check_cli.return_value = True | ||
|
|
||
| def test_dhcp_map_pri_map_t1(self): |
There was a problem hiding this comment.
Suggested change
| def test_dhcp_map_pri_map_t1(self): | |
| def test_dscp_map_pri_map_t1(self): |
| expected_cmd = '/usr/bin/cli --quiet -e --no-login-prompt switch sw01 dscp-map-pri-map-modify pri 0 name foo dsmap 40' | ||
| self.assertEqual(result['cli_cmd'], expected_cmd) | ||
|
|
||
| def test_dhcp_map_pri_map_t2(self): |
There was a problem hiding this comment.
Suggested change
| def test_dhcp_map_pri_map_t2(self): | |
| def test_dscp_map_pri_map_t2(self): |
| expected_cmd = '/usr/bin/cli --quiet -e --no-login-prompt switch sw01 dscp-map-pri-map-modify pri 1 name foo dsmap 8,10,12,14' | ||
| self.assertEqual(result['cli_cmd'], expected_cmd) | ||
|
|
||
| def test_dhcp_map_pri_map_t3(self): |
There was a problem hiding this comment.
Suggested change
| def test_dhcp_map_pri_map_t3(self): | |
| def test_dscp_map_pri_map_t3(self): |
Akasurde
approved these changes
Dec 25, 2018
ansibot
added
core_review
|
@Akasurde can you merge this? |
ansibot
added
the
stale_ci
ansibot
removed
the
stale_ci
|
@Akasurde can you merge this? Thanks, |
|
Can someone merge? its been quite some time now. Thanks, |
|
@Akasurde can you merge this? |
kbreit
pushed a commit
to kbreit/ansible
that referenced
this pull request
Jan 11, 2019
…#50142) * Pluribus Networks pn_dscp_map_pri_map module with Unit tests * Corrected method name in unit test script
knumskull
pushed a commit
to knumskull/ansible
that referenced
this pull request
Jan 21, 2019
…#50142) * Pluribus Networks pn_dscp_map_pri_map module with Unit tests * Corrected method name in unit test script
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Point feature of dscp map pri map for Pluribus Networks Netvisor switches
ISSUE TYPE
COMPONENT NAME
pn_dscp_map_pri_map.py module with unit tests.
ADDITIONAL INFORMATION
ansible 2.4.0.0
config file = None
configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /usr/local/lib/python2.7/dist-packages/ansible
executable location = /usr/local/bin/ansible
python version = 2.7.12 (default, Dec 4 2017, 14:50:18) [GCC 5.4.0 20160609]