Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcp: documentation update #50183

Merged
merged 2 commits into from Jan 3, 2019
Merged

gcp: documentation update #50183

merged 2 commits into from Jan 3, 2019

Conversation

Akasurde
Copy link
Member

SUMMARY
  • Update example about dynamic inventory
  • minor typo fixes in gcp_utils
  • Additional information about enabling inventory plugin in ansible.cfg

partially fixes: #44404

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs/docsite/rst/scenario_guides/guide_gce.rst
lib/ansible/module_utils/gcp_utils.py

@Akasurde
gcp: documentation update
4e13fe1 
* Update example about dynamic inventory
* minor typo fixes in gcp_utils
* Additional information about enabling inventory plugin in ansible.cfg

partially fixes: ansible#44404

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde mentioned this pull request Dec 20, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Dec 20, 2018

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 20, 2018
@Akasurde
Copy link
Member Author

cc @rambleraptor

chad-autry
chad-autry approved these changes Dec 20, 2018
View reviewed changes
Copy link

@chad-autry chad-autry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the issues you're attempting to address. I'd approve the changes going in.

To continue on with possible issues around the page as a whole, I believe there is an additional omission that authorizing the plugin does not authorize SSH to the instances. You still need to manage ssh keys somehow, which I've actually found quite difficult with GCE. In particular the final lines of the page "Note that use of the “add_host” module above creates a temporary, in-memory group. This means that a play in the same playbook can then manage machines in the ‘new_instances’ group, if so desired." implies to me that you should just be able to start running any module against the machine, when in fact I'm fairly sure you can't (Note: I've never tried creating instances with Ansible, just managing manually created instances)

@ansibot
Copy link
Contributor

ansibot commented Dec 28, 2018

cc @erjohnso
click here for bot help

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 28, 2018
samccann
samccann approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed one little nit.

@ansibot ansibot removed needs_triage Needs a first human triage before being processed. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 3, 2019
@samccann samccann merged commit ae404d1 into ansible:devel Jan 3, 2019
@Akasurde Akasurde deleted the i44404 branch January 4, 2019 07:09
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@Akasurde @kbreit
gcp: documentation update (ansible#50183)
bd1cfaf 
* gcp: documentation update

* Update example about dynamic inventory
* minor typo fixes in gcp_utils
* Additional information about enabling inventory plugin in ansible.cfg

partially fixes: ansible#44404

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ppuschmann
Copy link

Hi @samccann , hi @chad-autry ,

this documentation-update is also needed on Ansible 2.7.x.
How can we bring the updates to the live webpage?

@samccann
Copy link
Contributor

samccann commented Apr 1, 2019

Hi @ppuschmann . You can create a backport PR for this as described here:
https://docs.ansible.com/ansible/latest/community/development_process.html#backport-pull-request-process

This was referenced Apr 9, 2019
Closed
Merged
acozine pushed a commit that referenced this pull request Apr 10, 2019
@ppuschmann @acozine
Backport/2.7/50183 (#55035)
4b28413 
* gcp: documentation update (#50183)

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

(cherry picked from commit ae404d1)

* Add changelog-document for gcp_inventory improvement
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chad-autry chad-autry chad-autry approved these changes

@samccann samccann samccann approved these changes

@acozine acozine Awaiting requested review from acozine

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gcp_compute plugin does not work
5 participants
@Akasurde @ansibot @ppuschmann @samccann @chad-autry