Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport/2.7/50183 #55035

Merged
merged 2 commits into from Apr 10, 2019
Merged

Backport/2.7/50183 #55035

merged 2 commits into from Apr 10, 2019

Conversation

ppuschmann
Copy link

SUMMARY

Improve the documentation on gcp_compute as a dynamic inventory plugin.

Fixes parts of #44404

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs/docsite/rst/scenario_guides/guide_gce.rst

ADDITIONAL INFORMATION

This is a backport of documentation improvements done in #50183

Akasurde and others added 2 commits April 5, 2019 18:04
@Akasurde @ppuschmann
gcp: documentation update (#50183)
e173c54 
* gcp: documentation update

* Update example about dynamic inventory
* minor typo fixes in gcp_utils
* Additional information about enabling inventory plugin in ansible.cfg

partially fixes: #44404

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>


(cherry picked from commit ae404d1)
@ppuschmann
Add changelog-document for gcp_inventory improvement
7d195c0
@ansibot
Copy link
Contributor

ansibot commented Apr 9, 2019

cc @acozine @erjohnso @rambleraptor
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 9, 2019
@rambleraptor
Copy link
Contributor

Looks fine to me! I don't have merging abilities for this, so I'll need somebody from core to merge this.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 9, 2019
@acozine
Copy link
Contributor

acozine commented Apr 10, 2019

thanks for backporting this @ppuschmann

@acozine acozine merged commit 4b28413 into ansible:stable-2.7 Apr 10, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ppuschmann @ansibot @rambleraptor @acozine @Akasurde