Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pluribus Networks module for connection stat settings with UT's #50186

Merged
merged 2 commits into from Jan 7, 2019
Merged

Pluribus Networks module for connection stat settings with UT's #50186

merged 2 commits into from Jan 7, 2019

Conversation

rajaspachipulusu17
Copy link
Contributor

SUMMARY

Point feature of connection stat settings for Pluribus Networks Netvisor switches

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

pn_connection_stats_settings.py module with unit tests.

ADDITIONAL INFORMATION

ansible 2.4.0.0
config file = None
configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /usr/local/lib/python2.7/dist-packages/ansible
executable location = /usr/local/bin/ansible
python version = 2.7.12 (default, Dec 4 2017, 14:50:18) [GCC 5.4.0 20160609]

@ansibot
Copy link
Contributor

ansibot commented Dec 20, 2018

cc @NilashishC @Qalthos @amitsi @csharpe-pn @ganeshrn @gdpak @justjais @pdam @preetiparasar @rcarrillocruz @trishnaguha
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Dec 20, 2018

@rajaspachipulusu17, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Dec 20, 2018
@rajaspachipulusu17
Copy link
Contributor Author

@Akasurde can you merge this?

Thanks,
Rajas

Akasurde
Akasurde reviewed Dec 24, 2018
View reviewed changes
lib/ansible/modules/network/netvisor/pn_connection_stats_settings.py Outdated
type: str
state:
description:
- State the action to perform. Use 'update' to modify the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- State the action to perform. Use 'update' to modify the
- State the action to perform. Use C(update) to modify the

Akasurde
Akasurde requested changes Dec 24, 2018
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Dec 24, 2018
@rajaspachipulusu17
Copy link
Contributor Author

@Akasurde can you merge this?

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Jan 3, 2019
@ansibot ansibot added stale_review Updates were made after the last review and the last review is more than 7 days old. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Jan 7, 2019
@rajaspachipulusu17
Copy link
Contributor Author

@Akasurde can you merge this?

Thanks,
Rajas

@Akasurde Akasurde merged commit a1e1a42 into ansible:devel Jan 7, 2019
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@rajaspachipulusu17 @kbreit
Pluribus Networks module for connection stat settings with UT's (ansi…
e86fada 
…ble#50186)

* Pluribus Networks module for connection stat settings
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_review Updates were made after the last review and the last review is more than 7 days old. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rajaspachipulusu17 @ansibot @Akasurde