Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add colon after module name #50274

Merged
merged 3 commits into from Dec 22, 2018
Merged

Add colon after module name #50274

merged 3 commits into from Dec 22, 2018

Conversation

curry9999
Copy link
Contributor

SUMMARY
  • Add colon after module name
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/aws_kms_facts.py

ANSIBLE VERSION
devel

@ansibot
Copy link
Contributor

ansibot commented Dec 22, 2018

cc @willthames
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Dec 22, 2018

@curry9999, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Dec 22, 2018
dagwieers
dagwieers approved these changes Dec 22, 2018
View reviewed changes
Copy link
Contributor

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dagwieers dagwieers merged commit 4fe346d into ansible:devel Dec 22, 2018
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jan 4, 2019
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@curry9999 @kbreit
Add colon after module name (ansible#50274)
0431749 
* A colon is not described

* dddd

* Update aws_kms_facts.py
@curry9999 curry9999 deleted the comment-aws_kms_facts1 branch February 12, 2019 15:06
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@curry9999 @ansibot @dagwieers @sivel