New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc typo fixes #50371

Merged
merged 1 commit into from Jan 15, 2019

Conversation

@Akasurde
Copy link
Member

Akasurde commented Dec 28, 2018

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/inventory/data.py
lib/ansible/modules/identity/keycloak/keycloak_client.py
lib/ansible/parsing/dataloader.py
lib/ansible/playbook/task.py
lib/ansible/plugins/inventory/ini.py
lib/ansible/utils/encrypt.py

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 28, 2018

The test ansible-test sanity --test changelog [explain] failed with 1 error:

changelogs/fragments/with_-deprecation.yaml:0:0: (ERROR/3) Unknown target name: "with".

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Dec 28, 2018

@Akasurde Akasurde force-pushed the Akasurde:with_loop branch from 48d9fd2 to 97a88ff Dec 28, 2018

@gundalow
Copy link
Contributor

gundalow left a comment

Has this been agreed?

@Akasurde Akasurde force-pushed the Akasurde:with_loop branch from 97a88ff to 79a0070 Jan 2, 2019

@Akasurde Akasurde changed the title Show with_ type loop deprecation warnings Misc typo fixes Jan 2, 2019

@Akasurde

This comment has been minimized.

Copy link
Member

Akasurde commented Jan 2, 2019

@gundalow @bcoca I updated PR as per discussion. This PR is now just a minor typo fix. :)

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jan 2, 2019

@ansibot ansibot added module and removed needs_triage labels Jan 2, 2019

@bcoca

bcoca approved these changes Jan 2, 2019

@Akasurde Akasurde force-pushed the Akasurde:with_loop branch from 79a0070 to 88a34ca Jan 4, 2019

Minor typos
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

@Akasurde Akasurde force-pushed the Akasurde:with_loop branch from 88a34ca to 706da59 Jan 12, 2019

@Akasurde

This comment has been minimized.

Copy link
Member

Akasurde commented Jan 15, 2019

@gundalow Can you please review this ? Thanks.

@gundalow gundalow merged commit 4817dcd into ansible:devel Jan 15, 2019

1 check passed

Shippable Run 101913 status is SUCCESS.
Details

@Akasurde Akasurde deleted the Akasurde:with_loop branch Jan 15, 2019

@Akasurde

This comment has been minimized.

Copy link
Member

Akasurde commented Jan 15, 2019

@gundalow Thanks for the merge. @bcoca Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment