Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc typo fixes #50371

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Misc typo fixes #50371

merged 1 commit into from
Jan 15, 2019

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Dec 28, 2018 •
edited
Loading

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/inventory/data.py
lib/ansible/modules/identity/keycloak/keycloak_client.py
lib/ansible/parsing/dataloader.py
lib/ansible/playbook/task.py
lib/ansible/plugins/inventory/ini.py
lib/ansible/utils/encrypt.py

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. inventory Inventory category needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 28, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 28, 2018

The test ansible-test sanity --test changelog [explain] failed with 1 error:

changelogs/fragments/with_-deprecation.yaml:0:0: (ERROR/3) Unknown target name: "with".

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 28, 2018
gundalow
gundalow requested changes Dec 29, 2018
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been agreed?

@spoyd spoyd mentioned this pull request Dec 29, 2018
Closed
@Akasurde Akasurde changed the title Show with_ type loop deprecation warnings Misc typo fixes Jan 2, 2019
@Akasurde
Copy link
Member Author

Akasurde commented Jan 2, 2019

@gundalow @bcoca I updated PR as per discussion. This PR is now just a minor typo fix. :)

@ansibot
Copy link
Contributor

ansibot commented Jan 2, 2019

cc @eikef
click here for bot help

@ansibot ansibot added module This issue/PR relates to a module. and removed needs_triage Needs a first human triage before being processed. labels Jan 2, 2019
@Akasurde
Minor typos
706da59 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde
Copy link
Member Author

@gundalow Can you please review this ? Thanks.

@gundalow gundalow merged commit 4817dcd into ansible:devel Jan 15, 2019
@Akasurde Akasurde deleted the with_loop branch January 15, 2019 13:05
@Akasurde
Copy link
Member Author

@gundalow Thanks for the merge. @bcoca Thanks for the review.

knumskull pushed a commit to knumskull/ansible that referenced this pull request Jan 21, 2019
@Akasurde @knumskull
Minor typos (ansible#50371)
5d46486 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca approved these changes

@gundalow gundalow gundalow approved these changes

Assignees

@bcoca bcoca

@thaumos thaumos

Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. inventory Inventory category module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Akasurde @ansibot @bcoca @gundalow @thaumos