Issue #41447 - support AWS Aurora S3 privileges in mysql_user module #50454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
ansibot
added
the
stale_ci
ansibot
added
the
needs_repo
ansibot
removed
the
needs_triage
|
@bpennypacker Hi, When I merged https://github.com/ansible/ansible/pull/51478/files that caused a merge conflict in your PR. Would you be able to rebase then we can get this feature merged? |
|
We have a MySQL Working Group that's working through the backlog of MySQL PRs. |
ansibot
added
database
|
@bpennypacker Your branch does not contain a shippable.yml file. Please rebase your branch to trigger running of current tests. |
ansibot
added
the
needs_shippable
|
@bpennypacker Your branch does not contain a shippable.yml file. Please rebase your branch to trigger running of current tests. |
|
Has been replaced by #59663 please review that so we can get it merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #41447
Adds 'LOAD FROM S3' and 'SELECT INTO S3' to the list of valid privileges so AWS Aurora accounts can include them.
ISSUE TYPE
COMPONENT NAME
mysql_user
ADDITIONAL INFORMATION
See the discussion in #41447 for details.
In a nutshell, this PR allows AWS Aurora users to include the above mentioned privileges. This will not break exiting use of the mysql_user module in any way as it only adds to the list of valid privileges that the module checks for. Even if a regular mysql user were to attempt to reference these privileges they would simply receive an error from the mysql server rather than an error from ansible itself.
Example before adding this PR:
After: