Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arg_spec: remove elements= when type is not 'list'. #50484

Merged
merged 1 commit into from Jan 9, 2019
Merged

arg_spec: remove elements= when type is not 'list'. #50484

merged 1 commit into from Jan 9, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Hopefully fixes some of the tests failing for #50335.

CC @ganeshrn

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

openssl_csr
ios_user
manageiq_group
ucs_disk_group_policy

@felixfontein
Copy link
Contributor Author

Also see here.

@ansibot
Copy link
Contributor

ansibot commented Jan 3, 2019

cc @CiscoUcs @SDBrett @Spredzy @abellotti @cben @dagwieers @dsoper2 @evertmulder @gtanzillo @johnamcdonough @rcarrillocruz @SDBrett @sisudhir @trishnaguha @vallard @vvb @yaacov @zgalor
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 3, 2019

@felixfontein, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category remote_management Working Group: https://docs.ansible.com/ansible/latest/community/communication.html support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. ucs Cisco UCS community labels Jan 3, 2019
@ganeshrn ganeshrn mentioned this pull request Jan 4, 2019
Merged
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 4, 2019
@ganeshrn
Copy link
Member

ganeshrn commented Jan 7, 2019

cc @Spredzy

@ganeshrn ganeshrn merged commit 41de285 into ansible:devel Jan 9, 2019
@felixfontein felixfontein deleted the fix-argspec-types branch January 9, 2019 19:50
@felixfontein
Copy link
Contributor Author

@ganeshrn @evertmulder @dagwieers @Spredzy thanks for your reviews, and for merging!

kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@felixfontein @kbreit
Remove elements= from arg_spec when type is not 'list'. (ansible#50484)
4348c36
knumskull pushed a commit to knumskull/ansible that referenced this pull request Jan 21, 2019
@felixfontein @knumskull
Remove elements= from arg_spec when type is not 'list'. (ansible#50484)
e6b13bd
@dagwieers dagwieers added the cisco Cisco technologies label Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evertmulder evertmulder evertmulder approved these changes

@dagwieers dagwieers dagwieers approved these changes

@Spredzy Spredzy Spredzy approved these changes

@ganeshrn ganeshrn ganeshrn approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category remote_management Working Group: https://docs.ansible.com/ansible/latest/community/communication.html support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. ucs Cisco UCS community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@felixfontein @ansibot @ganeshrn @evertmulder @dagwieers @Spredzy