Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tqm._initialize_notified_handlers() is noop now #50713

Merged
merged 1 commit into from Jan 9, 2019
Merged

tqm._initialize_notified_handlers() is noop now #50713

merged 1 commit into from Jan 9, 2019

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Jan 9, 2019

SUMMARY

Missed in #49338?

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/executor/task_queue_manager.py

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 9, 2019
@sivel sivel self-requested a review January 9, 2019 14:56
s-hertel
s-hertel reviewed Jan 9, 2019
View reviewed changes
Copy link
Contributor

@s-hertel s-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Came to the same conclusion separately and made note of it here https://gist.github.com/s-hertel/21325671c8cd24b1e8804f96affce872#file-gist-yaml-L8.

@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jan 9, 2019
@bcoca bcoca merged commit 4c72ef1 into ansible:devel Jan 9, 2019
@sivel
Copy link
Member

sivel commented Jan 9, 2019

+1 you are all awesome

@mkrizek mkrizek deleted the remove-initialize_notified_handlers branch January 9, 2019 17:40
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@mkrizek @kbreit
tqm._initialize_notified_handlers() is noop now (ansible#50713)
563fe7c
knumskull pushed a commit to knumskull/ansible that referenced this pull request Jan 21, 2019
@mkrizek @knumskull
tqm._initialize_notified_handlers() is noop now (ansible#50713)
9e012f9
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-hertel s-hertel s-hertel left review comments

@sivel sivel Awaiting requested review from sivel

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mkrizek @sivel @s-hertel @bcoca @ansibot