-
Notifications
You must be signed in to change notification settings - Fork 23.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expect: utf-8' codec can't decode byte 0x80 enhancement #46556 #51505
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the other comments, this will also require a changelog to changelog/fragments
@@ -133,6 +133,7 @@ def main(): | |||
responses=dict(type='dict', required=True), | |||
timeout=dict(type='int', default=30), | |||
echo=dict(type='bool', default=False), | |||
codec_errors=dict(type='str'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing documentation. In addition you should probably support choices
and enumerate the possibilities provided by codecs
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sivel Will add the documentation
The test
|
Co-Authored-By: madhu222 <informmadhu@gmail.com>
Co-Authored-By: madhu222 <informmadhu@gmail.com>
The test
The test
The test
|
@madhu222 Are you still working on this? Thanks. |
close via alternate fix in #73255 |
SUMMARY
Modified the expect.py script to handle the utf-8 codec error
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/commands/expect.py
ADDITIONAL INFORMATION
If the reload is called after the telnet, it will show the utf-8 codec error. If I do the codec_error as replace option, the error is not seen. The example is shown below.