make editor selection aware of VISUAL env variable #51991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
|
This will require a changelog fragment in |
sivel
removed
the
needs_triage
zmyrgel
force-pushed
the
editor-env-fix
branch
from
9edb642
to
12e7125
Compare
ansibot
added
the
support:community
|
The test |
ansibot
added
needs_revision
mattclay
added
the
ci_verified
Vault editor should prefer editor set in VISUAL env variable and only then fallback to EDITOR. For more background, check: https://unix.stackexchange.com/questions/4859/visual-vs-editor-what-s-the-difference
zmyrgel
force-pushed
the
editor-env-fix
branch
from
12e7125
to
7f27f7b
Compare
|
The test |
ansibot
added
the
stale_ci
ansibot
removed
the
ci_verified
mattclay
added
the
ci_verified
samdoran
suggested changes
Jul 17, 2020
Comment on lines
+1097
to
+1099
| env_editor = os.environ.get('VISUAL') | ||
| if not env_editor: | ||
| env_editor = os.environ.get('EDITOR', 'vi') |
There was a problem hiding this comment.
Since we have used EDITOR historically, we should not change the default and need to start with EDITOR as the default. This precedence may not make sense, though, and we may need to add a config option to control this.
Suggested change
| env_editor = os.environ.get('VISUAL') | |
| if not env_editor: | |
| env_editor = os.environ.get('EDITOR', 'vi') | |
| env_editor = os.environ.get('EDITOR', os.environ.get('VISUAL', 'vi')) |
|
needs_info |
ansibot
added
the
needs_info
|
@zmyrgel This pullrequest is waiting for your response. Please respond or the pullrequest will be closed. |
|
@zmyrgel You have not responded to information requests in this pullrequest so we will assume it no longer affects you. If you are still interested in this, please create a new pullrequest with the requested information. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vault editor should prefer editor set in VISUAL env variable and only then fallback to EDITOR.
SUMMARY
When ansible-vault command opens editor it first looks for editor set in EDITOR env variable and falls back to vi if EDITOR is not set.
This fixes it so that it first looks for editor in set in VISUAL env variable, then in EDITOR and finally falls back to vi.
For background info:
https://unix.stackexchange.com/questions/4859/visual-vs-editor-what-s-the-difference
ISSUE TYPE
COMPONENT NAME
parsing
ADDITIONAL INFORMATION
Following should open ansible vault file in emacs after the change.