Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortinet's FortiOS system virtual wan link #52830

Merged
merged 2 commits into from
Mar 12, 2019
Merged

Fortinet's FortiOS system virtual wan link #52830

merged 2 commits into from
Mar 12, 2019

Conversation

migumun
Copy link
Contributor

@migumun migumun commented Feb 22, 2019

SUMMARY

Fortinet is adding Ansible support for FortiOS and FortiGate products. This module follows the same structure, guidelines and ideas given in previous approved module for a parallel feature of FortiGate (webfiltering): #37196
In this case we are providing a different functionality: "System Virtual WAN Link".

Please note that this will be part of other modules to come for FortiGate, including different functionalities: system, wireless-controller, firewall, webfilter, ips, web-proxy, wanopt, application, dlp spamfilter, log, vpn, certificate, user, dnsfilter, antivirus, report, waf, authentication, switch controller, endpoint-control and router. We plan to follow the same style, structure and usage as in the previous module in order to make it easier to comply with Ansible guidelines.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

fortios_system_virtual_wan_link

ANSIBLE VERSION
ansible 2.8.0.dev0 (new_module ddbbe5dfa5) last updated 2018/09/24 14:54:57 (GMT +200)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/magonzalez/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/magonzalez/ansible/lib/ansible
  executable location = /home/magonzalez/ansible/bin/ansible
  python version = 2.7.15rc1 (default, Apr 15 2018, 21:51:34) [GCC 7.3.0]

@ansibot
Copy link
Contributor

ansibot commented Feb 22, 2019

@bjolivot @thomnico

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Feb 22, 2019

@ansibot
Copy link
Contributor

ansibot commented Feb 22, 2019

@mamunozgonzalez, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. fortios Fortios community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Feb 22, 2019
@thomnico
Copy link

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 26, 2019
Copy link
Contributor

@NilashishC NilashishC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mamunozgonzalez This still has global and flatten_multilists_attributes(). Could you fix these two as discussed earlier?

@migumun
Copy link
Contributor Author

migumun commented Mar 12, 2019

Sure. Just added.

@NilashishC
Copy link
Contributor

That was quick. Thanks @mamunozgonzalez!

@NilashishC
Copy link
Contributor

@thomnico @mamunozgonzalez As discussed, we're merging these PRs for 2.8 release. However, we would really like to have these modules patched with the required fixes in the future. Thank you.

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_triage Needs a first human triage before being processed. shipit This PR is ready to be merged by Core labels Mar 12, 2019
@migumun
Copy link
Contributor Author

migumun commented Mar 12, 2019

You are welcome. Btw, can you also have a look to #52833? It is exactly as this one and the others we discussed previously, so I guess same comments and strategy applies.

@NilashishC NilashishC merged commit 20ec824 into ansible:devel Mar 12, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. fortios Fortios community module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants