-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fortinet's FortiOS system virtual wan link #52830
Fortinet's FortiOS system virtual wan link #52830
Conversation
As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add |
@mamunozgonzalez, just so you are aware we have a dedicated Working Group for network. |
shipit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mamunozgonzalez This still has global and flatten_multilists_attributes(). Could you fix these two as discussed earlier?
Sure. Just added. |
That was quick. Thanks @mamunozgonzalez! |
@thomnico @mamunozgonzalez As discussed, we're merging these PRs for 2.8 release. However, we would really like to have these modules patched with the required fixes in the future. Thank you. |
You are welcome. Btw, can you also have a look to #52833? It is exactly as this one and the others we discussed previously, so I guess same comments and strategy applies. |
SUMMARY
Fortinet is adding Ansible support for FortiOS and FortiGate products. This module follows the same structure, guidelines and ideas given in previous approved module for a parallel feature of FortiGate (webfiltering): #37196
In this case we are providing a different functionality: "System Virtual WAN Link".
Please note that this will be part of other modules to come for FortiGate, including different functionalities: system, wireless-controller, firewall, webfilter, ips, web-proxy, wanopt, application, dlp spamfilter, log, vpn, certificate, user, dnsfilter, antivirus, report, waf, authentication, switch controller, endpoint-control and router. We plan to follow the same style, structure and usage as in the previous module in order to make it easier to comply with Ansible guidelines.
ISSUE TYPE
COMPONENT NAME
fortios_system_virtual_wan_link
ANSIBLE VERSION