Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new maintenance group node module #53094

Merged
merged 3 commits into from
Mar 5, 2019
Merged

new maintenance group node module #53094

merged 3 commits into from
Mar 5, 2019

Conversation

sgerhart
Copy link
Contributor

SUMMARY

new aci module

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

maintenance_group_node_module

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Feb 28, 2019

@ansibot
Copy link
Contributor

ansibot commented Feb 28, 2019

@sgerhart, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added aci Cisco ACI community affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Feb 28, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 28, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/network/aci/aci_maintenance_group_node.py:0:0: E319 RETURN.filter_string.type: not a valid value for dictionary value @ data['filter_string']['type']. Got 'string'
lib/ansible/modules/network/aci/aci_maintenance_group_node.py:0:0: E319 RETURN.method.type: not a valid value for dictionary value @ data['method']['type']. Got 'string'
lib/ansible/modules/network/aci/aci_maintenance_group_node.py:0:0: E319 RETURN.raw.type: not a valid value for dictionary value @ data['raw']['type']. Got 'string'
lib/ansible/modules/network/aci/aci_maintenance_group_node.py:0:0: E319 RETURN.response.type: not a valid value for dictionary value @ data['response']['type']. Got 'string'
lib/ansible/modules/network/aci/aci_maintenance_group_node.py:0:0: E319 RETURN.url.type: not a valid value for dictionary value @ data['url']['type']. Got 'string'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 28, 2019
@dagwieers dagwieers added the cisco Cisco technologies label Mar 4, 2019
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_triage Needs a first human triage before being processed. labels Mar 4, 2019
@ansibot
Copy link
Contributor

ansibot commented Mar 5, 2019

@brunocalogero @jmcgill298 @mtorelli @rost-d @rsmeyers @schunduri @smnmtzgr

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 5, 2019
Copy link
Contributor

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dagwieers dagwieers merged commit f1fed45 into ansible:devel Mar 5, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aci Cisco ACI community affects_2.8 This issue/PR affects Ansible v2.8 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants