Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logged chap secret #53287

Merged
merged 1 commit into from Apr 10, 2019
Merged

Remove logged chap secret #53287

merged 1 commit into from Apr 10, 2019

Conversation

ndswartz
Copy link
Contributor

@ndswartz ndswartz commented Mar 4, 2019

SUMMARY

Removed a couple of logging statements that included a chap secret in the netapp_e_iscsi_target module.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

netapp_e_iscsi_target

ADDITIONAL INFORMATION
ansible 2.8.0.dev0
  config file = None
  configured module search path = [u'/home/swartzn/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/swartzn/ansible-dev/lib/ansible
  executable location = /home/swartzn/ansible-dev/bin/ansible
  python version = 2.7.15rc1 (default, Nov 12 2018, 14:31:15) [GCC 7.3.0]

@ansibot
Copy link
Contributor

ansibot commented Mar 4, 2019

cc @amit0701 @carchi8py @hulquest @lmprice @lonico @schmots1
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp owner_pr This PR is made by the module's maintainer. small_patch storage support:community This issue/PR relates to code supported by the Ansible community. labels Mar 4, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 10, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 18, 2019
@gundalow
Copy link
Contributor

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core automerge This PR was automatically merged by ansibot. and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 10, 2019
@ansibot ansibot merged commit eee5148 into ansible:devel Apr 10, 2019
@gundalow
Copy link
Contributor

@ndswartz Thank you for the fix
@lmprice Thank you for the review.

Merged into devel for release in Ansible 2.8

@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lmprice lmprice lmprice approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. netapp owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core small_patch storage support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ndswartz @ansibot @gundalow @lmprice @swartzn