Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logged chap secret #53287

Merged
merged 1 commit into from Apr 10, 2019
Merged

Remove logged chap secret #53287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/ansible/modules/storage/netapp/netapp_e_iscsi_target.py
View file
Open in desktop
Expand Up @@ -157,7 +157,7 @@ def __init__(self):

if not self.url.endswith('/'):
self.url += '/'
self._logger.info(self.chap_secret)

if self.chap_secret is not None:
if len(self.chap_secret) < 12 or len(self.chap_secret) > 16:
self.module.fail_json(msg="The provided CHAP secret is not valid, it must be between 12 and 16"
Expand Down Expand Up @@ -235,8 +235,6 @@ def apply_iscsi_settings(self):
update = True
body.update(dict(enableChapAuthentication=False))

self._logger.info(pformat(body))

if update and not self.check_mode:
try:
request(self.url + 'storage-systems/%s/iscsi/target-settings' % self.ssid, method='POST',
Expand Down