Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloudscale server password #53701

Merged
merged 2 commits into from
Mar 12, 2019
Merged

Cloudscale server password #53701

merged 2 commits into from
Mar 12, 2019

Conversation

gaudenz
Copy link
Contributor

@gaudenz gaudenz commented Mar 12, 2019

SUMMARY

Recent revisions of the cloudscale.ch API allow setting a password for a
server. Add this option to the cloudscale_server module.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

cloudscale_server

@gaudenz
cloudscale_server: remove required parameter check
28b0bab 
The valid parameter combinations are already checked by the API. There
is no need to check a subset of this in the Ansible module as well. This
makes it more likely that future changes in the API won't require
changes in the Ansible module.
@gaudenz
cloudscale_server: add password parameter
0f704df 
Recent revisions of the cloudscale.ch API allow setting a password for a
server. Add this option to the cloudscale_server module.
@ansibot
Copy link
Contributor

ansibot commented Mar 12, 2019

cc @resmo
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Mar 12, 2019
@resmo
Copy link
Contributor

resmo commented Mar 12, 2019

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Mar 12, 2019
@resmo
Copy link
Contributor

resmo commented Mar 12, 2019

thanks!

@resmo resmo merged commit 8111425 into ansible:devel Mar 12, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaudenz @ansibot @resmo