Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add administrative up/down option. #54431

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@sergun4ik
Copy link

commented Mar 26, 2019

Adding an option to control the administrative state of a layer 3 interface. Up/Down represent "no shutdown" and "shutdown" respectively.

Add administrative up/down option.
Adding an option to control the administrative state of a layer 3 interface. Up/Down represent "no shutdown" and "shutdown" respectively.
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

@sergun4ik, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/network/ios/ios_l3_interface.py:185:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/network/ios/ios_l3_interface.py:212:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/network/ios/ios_l3_interface.py:253:22: undefined-variable Undefined variable 'updown'

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/network/ios/ios_l3_interface.py:185:1: W293 blank line contains whitespace
lib/ansible/modules/network/ios/ios_l3_interface.py:212:1: W293 blank line contains whitespace
lib/ansible/modules/network/ios/ios_l3_interface.py:296:20: E128 continuation line under-indented for visual indent

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/network/ios/ios_l3_interface.py:0:0: E309 version_added for new option (updown) should be '2.8'. Currently StrictVersion ('0.0')
lib/ansible/modules/network/ios/ios_l3_interface.py:0:0: E324 Argument 'updown' in argument_spec defines default as ('up') but documentation defines default as (None)
lib/ansible/modules/network/ios/ios_l3_interface.py:0:0: E326 Argument 'updown' in argument_spec defines choices as (['up', 'down']) but documentation defines choices as ([])

click here for bot help

@ansibot ansibot removed the ci_verified label Mar 27, 2019

@sergun4ik

This comment has been minimized.

Copy link
Author

commented on d83dfd8 Mar 27, 2019

Fixed issues highlighted in previous sanity check.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/network/ios/ios_l3_interface.py:255:22: undefined-variable Undefined variable 'updown'

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/ios/ios_l3_interface.py:0:0: E309 version_added for new option (updown) should be '2.8'. Currently StrictVersion ('0.0')

click here for bot help

@ansibot ansibot added the ci_verified label Mar 27, 2019

@ansibot ansibot removed the ci_verified label Mar 27, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/network/ios/ios_l3_interface.py:256:22: undefined-variable Undefined variable 'updown'

click here for bot help

@ansibot ansibot added the ci_verified label Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.