Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add administrative up/down option. #54431

Closed
wants to merge 4 commits into from
Closed

Add administrative up/down option. #54431

wants to merge 4 commits into from

Conversation

sergun4ik
Copy link

Adding an option to control the administrative state of a layer 3 interface. Up/Down represent "no shutdown" and "shutdown" respectively.

@sergun4ik
Add administrative up/down option.
db3d2f5 
Adding an option to control the administrative state of a layer 3 interface. Up/Down represent "no shutdown" and "shutdown" respectively.
@ansibot
Copy link
Contributor

ansibot commented Mar 26, 2019

cc @ganeshrn @rcarrillocruz
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Mar 26, 2019

@sergun4ik, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Mar 26, 2019
@ansibot
Copy link
Contributor

ansibot commented Mar 26, 2019

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/network/ios/ios_l3_interface.py:185:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/network/ios/ios_l3_interface.py:212:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/network/ios/ios_l3_interface.py:253:22: undefined-variable Undefined variable 'updown'

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/network/ios/ios_l3_interface.py:185:1: W293 blank line contains whitespace
lib/ansible/modules/network/ios/ios_l3_interface.py:212:1: W293 blank line contains whitespace
lib/ansible/modules/network/ios/ios_l3_interface.py:296:20: E128 continuation line under-indented for visual indent

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/network/ios/ios_l3_interface.py:0:0: E309 version_added for new option (updown) should be '2.8'. Currently StrictVersion ('0.0')
lib/ansible/modules/network/ios/ios_l3_interface.py:0:0: E324 Argument 'updown' in argument_spec defines default as ('up') but documentation defines default as (None)
lib/ansible/modules/network/ios/ios_l3_interface.py:0:0: E326 Argument 'updown' in argument_spec defines choices as (['up', 'down']) but documentation defines choices as ([])

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 26, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Mar 27, 2019
@ansibot
Copy link
Contributor

ansibot commented Mar 27, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/network/ios/ios_l3_interface.py:255:22: undefined-variable Undefined variable 'updown'

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/ios/ios_l3_interface.py:0:0: E309 version_added for new option (updown) should be '2.8'. Currently StrictVersion ('0.0')

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Mar 27, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Mar 27, 2019
@ansibot
Copy link
Contributor

ansibot commented Mar 27, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/network/ios/ios_l3_interface.py:256:22: undefined-variable Undefined variable 'updown'

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Mar 27, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 27, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 4, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 23, 2019

cc @justjais
click here for bot help

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. and removed core_review In order to be merged, this PR must follow the core review workflow. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Aug 24, 2019
@ansibot ansibot removed the new_module This PR includes a new module. label Mar 27, 2020
@ansibot ansibot added collection Related to Ansible Collections work collection:cisco.ios needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@danielmellado
Copy link
Contributor

Thank you very much for your interest in Ansible. This plugin is no longer maintained in this repository and has been migrated to https://github.com/ansible-collections/cisco.ios
Please re-submit this PR in the above repository.
If you have further questions please stop by IRC or the mailing list:

IRC: #ansible-network on irc.freenode.net
mailing list: https://groups.google.com/forum/#!forum/ansible-project

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jun 2, 2020
@ansible ansible locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cisco Cisco technologies collection:cisco.ios collection Related to Ansible Collections work ios Cisco IOS community module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category new_contributor This PR is the first contribution by a new community member. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sergun4ik @ansibot @danielmellado @sivel