Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpm serial port info #55114

Merged
merged 8 commits into from Apr 22, 2019

Conversation

Projects
None yet
6 participants
@syncpak
Copy link
Contributor

syncpak commented Apr 10, 2019

SUMMARY

Added the module cpm_serial_port_info to be able query serial port parameters of WTI OOB and PDU devices.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

cpm_serial_port_info

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Apr 10, 2019

@wtinetworkgear

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@samdoran
Copy link
Member

samdoran left a comment

The module works well. Just a minor adjustment to one of the fields.

@syncpak

This comment has been minimized.

Copy link
Contributor Author

syncpak commented Apr 11, 2019

Hi @samdoran , the changes look awesome and i believe i committed them, but the Checks keeps failing.

@samdoran

This comment has been minimized.

Copy link
Member

samdoran commented Apr 11, 2019

The current failure is a sanity test failure:

lib/ansible/modules/remote_management/cpm/cpm_serial_port_info.py:156:5: E303 too many blank lines (2)
@syncpak

This comment has been minimized.

Copy link
Contributor Author

syncpak commented Apr 11, 2019

Sorry about that, sanity check passes now

@syncpak

This comment has been minimized.

Copy link
Contributor Author

syncpak commented Apr 15, 2019

shipit

@wtinetworkgear

This comment has been minimized.

Copy link

wtinetworkgear commented Apr 15, 2019

shipit

Update module documentation and default port
Set port to ‘*’ by default so all dat is returned instead of erroring.
Add documentation on example output.
Update examples to reflect list parameter for port field.
Change version_added to 2.9

@samdoran samdoran merged commit d18beee into ansible:devel Apr 22, 2019

1 check passed

Shippable Run 119911 status is SUCCESS.
Details

@sivel sivel removed the needs_triage label Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.