Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cpm serial port info #55114

Merged
merged 8 commits into from Apr 22, 2019
Merged

Cpm serial port info #55114

merged 8 commits into from Apr 22, 2019

Conversation

syncpak
Copy link
Contributor

@syncpak syncpak commented Apr 10, 2019

SUMMARY

Added the module cpm_serial_port_info to be able query serial port parameters of WTI OOB and PDU devices.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

cpm_serial_port_info

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. remote_management Working Group: https://docs.ansible.com/ansible/latest/community/communication.html support:community This issue/PR relates to code supported by the Ansible community. labels Apr 10, 2019
@ansibot
Copy link
Contributor

ansibot commented Apr 10, 2019

@wtinetworkgear

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@syncpak syncpak mentioned this pull request Apr 11, 2019
Merged
samdoran
samdoran suggested changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@samdoran samdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module works well. Just a minor adjustment to one of the fields.

lib/ansible/modules/remote_management/cpm/cpm_serial_port_info.py Outdated Show resolved Hide resolved
lib/ansible/modules/remote_management/cpm/cpm_serial_port_info.py Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 11, 2019
@syncpak
Copy link
Contributor Author

syncpak commented Apr 11, 2019

Hi @samdoran , the changes look awesome and i believe i committed them, but the Checks keeps failing.

@samdoran
Copy link
Contributor

The current failure is a sanity test failure:

lib/ansible/modules/remote_management/cpm/cpm_serial_port_info.py:156:5: E303 too many blank lines (2)

@syncpak
Copy link
Contributor Author

syncpak commented Apr 11, 2019

Sorry about that, sanity check passes now

@syncpak
Copy link
Contributor Author

syncpak commented Apr 15, 2019

shipit

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 15, 2019
@wtinetworkgear
Copy link

shipit

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Apr 17, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 17, 2019
@samdoran
Update module documentation and default port
f7576fd 
Set port to ‘*’ by default so all dat is returned instead of erroring.
Add documentation on example output.
Update examples to reflect list parameter for port field.
Change version_added to 2.9
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 18, 2019
@samdoran samdoran merged commit d18beee into ansible:devel Apr 22, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 23, 2019
ndclt pushed a commit to ndclt/ansible that referenced this pull request Jun 13, 2019
@syncpak @ndclt
Add WTI OOB and PDU Device info module (ansible#55114)
30c5441
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
@syncpak syncpak deleted the cpm_serial_port_info branch November 1, 2019 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran samdoran approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. remote_management Working Group: https://docs.ansible.com/ansible/latest/community/communication.html support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@syncpak @ansibot @samdoran @wtinetworkgear @sivel @mattclay