New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vrf option to static routes #55298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@twbowman, just so you are aware we have a dedicated Working Group for network. |
ansibot
added
affects_2.9
This issue/PR affects Ansible v2.9
feature
This issue/PR relates to a feature request.
module
This issue/PR relates to a module.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
needs_triage
Needs a first human triage before being processed.
networking
Network category
new_contributor
This PR is the first contribution by a new community member.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
support:network
This issue/PR relates to code supported by the Ansible Network Team.
labels
Apr 15, 2019
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
and removed
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Apr 15, 2019
ansibot
removed
the
new_contributor
This PR is the first contribution by a new community member.
label
Apr 24, 2019
Qalthos
suggested changes
Apr 26, 2019
ansibot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
needs_triage
Needs a first human triage before being processed.
labels
Apr 26, 2019
ansibot
removed
the
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
label
Apr 26, 2019
Qalthos
approved these changes
May 1, 2019
ndclt
pushed a commit
to ndclt/ansible
that referenced
this pull request
Jun 13, 2019
* added vrf to static route * fix pylint errors * version added 2.9 for vrf * removed undocmented return values * Update README.rst
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.9
This issue/PR affects Ansible v2.9
feature
This issue/PR relates to a feature request.
module
This issue/PR relates to a module.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
networking
Network category
support:network
This issue/PR relates to code supported by the Ansible Network Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Provide the option to add vrf besides the default vrf to static route commands.
ISSUE TYPE
COMPONENT NAME
eos_static_route
vrf: add static route to a non default vrf
ADDITIONAL INFORMATION
We need to add static routes to VRFs other than the default one. I modified eos_static_route.py to achieve this.
I wrote a test playbook, see below, that checks ip route addition and deletion for the default VRF and a new vrf.
This is the result of the test playbook using the modified eos_static_route.py.
Below is an ansible playbook that i used to test the change: