SX5-868 New keycloak_role module.

.github/BOTMETA.yml

@@ -191,7 +191,7 @@ files:
     maintainers: $team_solaris
   $modules/cloud/univention/: keachi
   $modules/cloud/vmware/: &vmware
-    ignored: cigamit jcpowermac mtnbikenc tchernomax
+    ignored: cigamit jcpowermac mtnbikenc tchernomax ckotte
     keywords: [ esx, vcenter, vcsa, vcsim, vsphere ]
     labels: [ cloud, vmware ]
     maintainers: $team_vmware
@@ -693,7 +693,12 @@ files:
     maintainers: $team_google
     supershipit: $team_google
   $module_utils/gitlab.py: *gitlab
-  $module_utils/hwc_utils.py: *huawei
+  $module_utils/hwc_utils.py: &huawei_hwc
+    <<: *huawei
+    support: community
+    labels:
+      - networking
+      - huawei
   $module_utils/ipa.py:
     maintainers: $team_ipa
   $module_utils/k8s:
@@ -1197,7 +1202,7 @@ files:
     keywords:
       - vmware inventory
       - vmware dynamic inventory plugin
-    ignored: cigamit jcpowermac mtnbikenc tchernomax
+    ignored: cigamit jcpowermac mtnbikenc tchernomax ckotte
   $plugins/inventory/vultr.py: *vultr
   $plugins/inventory/yaml.py:
     support: core
@@ -1424,7 +1429,7 @@ files:
     <<: *docker
     support: community
   test/units/module_utils/facts/network/test_generic_bsd.py: *bsd
-  test/units/module_utils/hwc: *huawei
+  test/units/module_utils/hwc: *huawei_hwc
   test/units/module_utils/acme: *crypto
   test/units/module_utils/xenserver/: bvitnik
   test/units/modules/cloud/docker:
@@ -1507,11 +1512,11 @@ macros:
   team_rabbitmq: chrishoffman manuel-sousa hyperized
   team_redfish: jose-delarosa mraineri tomasg2012 billdodd
   team_rhn: alikins barnabycourt FlossWare vritant
-  team_scaleway: sieben Spredzy abarbare Anthony25 pilou-
+  team_scaleway: remyleone abarbare DenBeke jerome-quere kindermoumoute QuentinBrosse
   team_solaris: bcoca dagwieers fishman jpdasma jasperla mator scathatheworm troy2914 xen0l
   team_tower: ghjm matburt wwitzel3 ryanpetrello rooftopcellist AlanCoding jladdjr kdelee
   team_ucs: dsoper2 movinalot SDBrett vallard vvb
-  team_vmware: Akasurde dav1x warthog9 ckotte Tomorrow9 goneri
+  team_vmware: Akasurde dav1x warthog9 Tomorrow9 goneri
   team_virt: joshainglis karmab
   team_vultr: resmo Spredzy
   team_windows: dagwieers jborean93 jhawkesworth nitzmahone

changelogs/fragments/48971-meraki_ssid-docs.yml

@@ -0,0 +1,2 @@
+minor_changes:
+  - meraki_ssid - Add examples to documentation.

changelogs/fragments/53372-vmware_guest_facts-add_moid.yml

@@ -0,0 +1,2 @@
+minor_changes:
+- Add managed object identifier (moId) and vim reference (vimref) of virtual machine in guest facts (https://github.com/ansible/ansible/issues/53372).

changelogs/fragments/53385-docker-privilege-escalation.yml

@@ -0,0 +1,4 @@
+---
+bugfixes:
+ - Fix privilege escalation support for the docker connection plugin when
+   credentials need to be supplied (e.g. sudo with password).

changelogs/fragments/53409-rds_instance-remove-hardcoded-license-models.yaml

@@ -0,0 +1,3 @@
+bugfixes:
+  - rds_instance - Don't hardcode the license models because there are accepted values undocumented by AWS.
+    Rely on the exception handling instead to provide a helpful error for invalid license models.

changelogs/fragments/53576-meraki-unchanged-returns.yml

@@ -0,0 +1,2 @@
+minor_changes:
+  - "meraki_* - Meraki modules now return data when no changes are made."

changelogs/fragments/53601-meraki_switchport_improve_vlan_reliability.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- "meraki_switchport - improve reliability with native VLAN functionality."

changelogs/fragments/54335-vmware_guest-memory_reservation.yml

@@ -0,0 +1,2 @@
+minor_changes:
+  - Remove duplicate implementation of memory reservation parameter in vmware_guest (https://github.com/ansible/ansible/issues/54335).

changelogs/fragments/55224-ec2_instance-idempotent-tags.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+  - ec2_instance - make Name tag idempotent (https://github.com/ansible/ansible/pull/55224)

changelogs/fragments/55643-network-facts-iscsi.yaml

@@ -0,0 +1,2 @@
+minor_changes:
+  - refactor iSCSI network facts for AIX and HP-UX, add unit test, remove external grep call

changelogs/fragments/55678-xenserver_guest-change-wait_for_ip_address-behaviour-and-other.yaml

@@ -0,0 +1,6 @@
+minor_changes:
+  - xenserver_guest - wait_for_ip_address is now ignored when state=absent (https://github.com/ansible/ansible/issues/55348).
+
+bugfixes:
+  - xenserver_guest - proper error message is shown when maximum number of network interfaces is reached and multiple network interfaces are added at once.
+  - xenserver_guest - fixed an issue where VM whould be powered off even though check mode is used if reconfiguration requires VM to be powered off.

changelogs/fragments/55716-ec2_instance_int_volume_size.yml

@@ -0,0 +1,2 @@
+bugfixes:
+  - ec2_instance - Ensures ``ebs.volume_size`` and ``ebs.iops`` are ``int`` to avoid issues with Jinja2 templating

changelogs/fragments/55881-os-network-mtu-support-on-create-update.yml

@@ -0,0 +1,3 @@
+---
+minor_changes:
+  - os_network - added MTU support when creating/updating a network

changelogs/fragments/55930-vsphere_copy_for_esxi.yaml

@@ -0,0 +1,4 @@
+minor_changes:
+- vsphere_copy - The module can now also be used with standalone ESXi.
+- vsphere_copy - The ``host`` and ``login`` parameters are deprecated, use `hostname` and ``username``
+  like for the other VMware modules.

changelogs/fragments/55938-dnf-fix-wildcard-matching-state-absent.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+  - "dnf - fix wildcard matching for state: absent (https://github.com/ansible/ansible/issues/55938)"

changelogs/fragments/56012-docker_container-oom-version.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- "docker_container - ``oom_killer`` and ``oom_score_adj`` options are available since docker-py 1.8.0, not 2.0.0 as assumed by the version check."

changelogs/fragments/56021-vmware_guest_disk-use_instance_uuid.yml

@@ -0,0 +1,2 @@
+minor_changes:
+- vmware_guest_disk module supports use_instance_uuid parameter since Ansible 2.8 (https://github.com/ansible/ansible/issues/56021).

changelogs/fragments/56125-vmware_vm_facts-use_folder.yml

@@ -0,0 +1,2 @@
+minor_changes:
+- vmware_vm_facts supports folder as a filter to gather fact for VM (https://github.com/ansible/ansible/issues/56125).

changelogs/fragments/56150-add-if-match-header-to-patch-requests.yaml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+- redfish_command - add If-Match etag header to Redfish PATCH requests (https://github.com/ansible/ansible/issues/56050)

changelogs/fragments/56155-openssl_certificate-passphrase.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- "openssl_certificate - fix private key passphrase handling for ``cryptography`` backend."

changelogs/fragments/56357-ibm-storage-unwanted-args-cause-failure.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- ibm_storage - Added a check for null fields in ibm_storage utils module.

changelogs/fragments/56407_eos_use_sessions.yaml

@@ -0,0 +1,2 @@
+minor_changes:
+  - eos_use_sessions is now type boolean instead of int.

changelogs/fragments/56442-spidermila-vmware_guest_disk_facts-scsi-controller-bus-number.yaml

@@ -0,0 +1,2 @@
+minor_changes:
+- vmware_guest_disk_facts module - added bus number of the SCSI controller to the output (https://github.com/ansible/ansible/pull/56442)

changelogs/fragments/56458-yum-fix-false-error-msg-autoremove.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+  - yum - Fix false error message about autoremove not being supported (https://github.com/ansible/ansible/issues/56458)

changelogs/fragments/56649-docker-image-lookup-by-digest.yml

@@ -0,0 +1,4 @@
+bugfixes:
+  - docker_container - Add support for image lookups by digest. Fixes the detection of digest changes.
+  - docker_image - Add support for image lookups by digest. Fixes the detection of digest changes.
+  - docker_image_info - Add support for image lookups by digest. Fixes the detection of digest changes.

changelogs/fragments/ansible-adhoc.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+  - allow include_role to work with ansible command

changelogs/fragments/cgroup-perf-recap-fix-open-files.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- cgroup_perf_recap - When not using file_per_task, make sure we don't prematurely close the perf files

changelogs/fragments/include_tasks_listen.yml

@@ -0,0 +1,3 @@
+bugfixes:
+- include_tasks - whitelist ``listen`` as a valid keyword
+  (https://github.com/ansible/ansible/issues/56580)

changelogs/fragments/module_default_fixes.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+    - refactored into function and use in some action plugins to match actual module used, made precedence very clear in code.

changelogs/fragments/mysql_user-fix-versions-compatibilities-regression.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- "mysql_user: fix regression introduced when fixing MariaDB/MySQL multiple versions handling"

changelogs/fragments/python_requirements_facts_dashes.yml

@@ -0,0 +1,2 @@
+bugfixes:
+  - allow python_requirements_facts to report on dependencies containing dashes

changelogs/fragments/removed_obsolete_configs.yml

@@ -0,0 +1,2 @@
+minor_changes:
+    - All previouslly deprecated sudo/su and module locale global settings have been removed.

changelogs/fragments/stat_no_md5.yml

@@ -0,0 +1,2 @@
+minor_changes:
+    - removed previously deprecated ``get_md5`` option from M(stat) module.

changelogs/fragments/sysctl-invalid-value.yml

@@ -0,0 +1,2 @@
+bugfixes:
+  - "sysctl: the module now also checks the output of STDERR to report if values are correctly set (https://github.com/ansible/ansible/pull/55695)"

changelogs/fragments/urls-ipv6-redirects.yml

@@ -0,0 +1,4 @@
+bugfixes:
+- urls - Handle redirects properly for IPv6 address by not splitting on ``:``
+  and rely on already parsed hostname and port values
+  (https://github.com/ansible/ansible/issues/56258)

changelogs/fragments/vmware_check_ssl_cert.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- vmware - The VMware modules now enable the SSL certificate check unless ``validate_certs`` is ``false``.

changelogs/fragments/vmware_datastore_facts.yaml

@@ -0,0 +1,2 @@
+minor_changes:
+    - vmware_datastore_facts - When no datastore was found, returns an empty list.

changelogs/fragments/vmware_maintenance_mode_params.yaml

@@ -0,0 +1,2 @@
+minor_changes:
+    - vmware_datastore_maintenancemode - Raise an error if the datastore does not exist.  

changelogs/fragments/winrm-input-failures.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- winrm - Fix issue when attempting to parse CLIXML on send input failure

changelogs/fragments/yum-enable-missing-repo.yaml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - "yum - gracefully handle failure case of enabling a non existent repo, as the yum cli does (Fixes https://github.com/ansible/ansible/issues/52582)"

contrib/inventory/vagrant.py

@@ -7,7 +7,7 @@
 
     config.vm.provision :ansible do |ansible|
       ansible.playbook = "./provision/your_playbook.yml"
-      ansible.inventory_file = "./provision/inventory/vagrant.py"
+      ansible.inventory_path = "./provision/inventory/vagrant.py"
       ansible.verbose = true
     end
 """

docs/bin/plugin_formatter.py

@@ -11,6 +11,7 @@
 
 import datetime
 import glob
+import json
 import optparse
 import os
 import re
@@ -52,7 +53,7 @@ def html_escape(text, quote=True):
 
 # if a module is added in a version of Ansible older than this, don't print the version added information
 # in the module documentation because everyone is assumed to be running something newer than this already.
-TOO_OLD_TO_BE_NOTABLE = 2.0
+TOO_OLD_TO_BE_NOTABLE = 2.3
 
 # Get parent directory of the directory this script lives in
 MODULEDIR = os.path.abspath(os.path.join(
@@ -399,6 +400,10 @@ def jinja2_environment(template_dir, typ, plugin_type):
         # Jinja < 2.10
         env.filters['max'] = do_max
 
+    if 'tojson' not in env.filters:
+        # Jinja < 2.9
+        env.filters['tojson'] = json.dumps
+
     templates = {}
     if typ == 'rst':
         env.filters['rst_ify'] = rst_ify

docs/docsite/rst/community/committer_guidelines.rst

@@ -152,3 +152,5 @@ Individuals who've been asked to become a part of this group have generally been
 +---------------------+----------------------+--------------------+----------------------+
 | Sandra McCann       | samccann             | samccann           |                      |
 +---------------------+----------------------+--------------------+----------------------+
+| Felix Fontein       | felixfontein         | felixfontein       | felix@fontein.de     |
++---------------------+----------------------+--------------------+----------------------+

docs/docsite/rst/community/development_process.rst

@@ -225,7 +225,7 @@ We do **not** backport features.
 
    These instructions assume that:
 
-    * ``stable-2.7`` is the targeted release branch for the backport
+    * ``stable-2.8`` is the targeted release branch for the backport
     * ``https://github.com/ansible/ansible.git`` is configured as a
       ``git remote`` named ``upstream``. If you do not use
       a ``git remote`` named ``upstream``, adjust the instructions accordingly.
@@ -238,7 +238,7 @@ We do **not** backport features.
    ::
 
        git fetch upstream
-       git checkout -b backport/2.7/[PR_NUMBER_FROM_DEVEL] upstream/stable-2.7
+       git checkout -b backport/2.8/[PR_NUMBER_FROM_DEVEL] upstream/stable-2.8
 
 #. Cherry pick the relevant commit SHA from the devel branch into your feature
    branch, handling merge conflicts as necessary:
@@ -253,18 +253,18 @@ We do **not** backport features.
 
    ::
 
-       git push origin backport/2.7/[PR_NUMBER_FROM_DEVEL]
+       git push origin backport/2.8/[PR_NUMBER_FROM_DEVEL]
 
-#. Submit the pull request for ``backport/2.7/[PR_NUMBER_FROM_DEVEL]``
-   against the ``stable-2.7`` branch
+#. Submit the pull request for ``backport/2.8/[PR_NUMBER_FROM_DEVEL]``
+   against the ``stable-2.8`` branch
 
 #. The Release Manager will decide whether to merge the backport PR before
    the next minor release. There isn't any need to follow up. Just ensure that the automated
    tests (CI) are green.
 
 .. note::
 
-    The choice to use ``backport/2.7/[PR_NUMBER_FROM_DEVEL]`` as the
+    The choice to use ``backport/2.8/[PR_NUMBER_FROM_DEVEL]`` as the
     name for the feature branch is somewhat arbitrary, but conveys meaning
     about the purpose of that branch. It is not required to use this format,
     but it can be helpful, especially when making multiple backport PRs for

docs/docsite/rst/conf.py

@@ -34,7 +34,7 @@
 # the repository version needs to be the one that is loaded:
 sys.path.insert(0, os.path.abspath(os.path.join('..', '..', '..', 'lib')))
 
-VERSION = '2.7'
+VERSION = '2.8'
 AUTHOR = 'Ansible, Inc'
 
 

docs/docsite/rst/dev_guide/developing_modules_best_practices.rst

@@ -16,7 +16,7 @@ Scoping your module(s)
 Especially if you want to contribute your module(s) back to Ansible Core, make sure each module includes enough logic and functionality, but not too much. If you're finding these guidelines tricky, consider :ref:`whether you really need to write a module <module_dev_should_you>` at all.
 
 * Each module should have a concise and well-defined functionality. Basically, follow the UNIX philosophy of doing one thing well.
-* Do not add ``list`` or ``info`` state options to an existing module - create a new ``_facts`` module.
+* Do not add ``list`` or ``info`` state options to an existing module - create a new ``_info`` or ``_facts`` module.
 * Modules should not require that a user know all the underlying options of an API/tool to be used. For instance, if the legal values for a required module parameter cannot be documented, the module does not belong in Ansible Core.
 * Modules should encompass much of the logic for interacting with a resource. A lightweight wrapper around a complex API forces users to offload too much logic into their playbooks. If you want to connect Ansible to a complex API, :ref:`create multiple modules <developing_modules_in_groups>` that interact with smaller individual pieces of the API.
 * Avoid creating a module that does the work of other modules; this leads to code duplication and divergence, and makes things less uniform, unpredictable and harder to maintain. Modules should be the building blocks. If you are asking 'how can I have a module execute other modules' ... you want to write a role.
@@ -152,7 +152,7 @@ Ansible conventions offer a predictable user interface across all modules, playb
 * Use consistent parameters (arguments) within your module(s).
 * Normalize parameters with other modules - if Ansible and the API your module connects to use different names for the same parameter, add aliases to your parameters so the user can choose which names to use in tasks and playbooks.
 * Return facts from ``*_facts`` modules in the ``ansible_facts`` field of the :ref:`result dictionary<common_return_values>` so other modules can access them.
-* Implement ``check_mode`` in all ``*_facts`` modules. Playbooks which conditionalize based on fact information will only conditionalize correctly in ``check_mode`` if the facts are returned in ``check_mode``. Usually you can add ``supports_check_mode=True`` when instantiating ``AnsibleModule``.
+* Implement ``check_mode`` in all ``*_info`` and ``*_facts`` modules. Playbooks which conditionalize based on fact information will only conditionalize correctly in ``check_mode`` if the facts are returned in ``check_mode``. Usually you can add ``supports_check_mode=True`` when instantiating ``AnsibleModule``.
 * Use module-specific environment variables. For example, if you use the helpers in ``module_utils.api`` for basic authentication with ``module_utils.urls.fetch_url()`` and you fall back on environment variables for default values, use a module-specific environment variable like :code:`API_<MODULENAME>_USERNAME` to avoid conflict between modules.
 * Keep module options simple and focused - if you're loading a lot of choices/states on an existing option, consider adding a new, simple option instead.
 * Keep options small when possible. Passing a large data structure to an option might save us a few tasks, but it adds a complex requirement that we cannot easily validate before passing on to the module.

docs/docsite/rst/dev_guide/developing_modules_checklist.rst

@@ -26,8 +26,8 @@ To contribute a module to Ansible, you must:
 * minimize module dependencies
 * support :ref:`check_mode <check_mode_dry>` if possible
 * ensure your code is readable
-* if a module is named ``<something>_facts``, it should be because its main purpose is returning ``ansible_facts``. Do not name modules that do not do this with ``_facts``.
-* Modules that query/return general information (and not ``ansible_facts``) should be named ``_info``.
+* if a module is named ``<something>_facts``, it should be because its main purpose is returning ``ansible_facts``. Do not name modules that do not do this with ``_facts``. Only use ``ansible_facts`` for information that is specific to the host machine, for example network interfaces and their configuration, which operating system and which programs are installed.
+* Modules that query/return general information (and not ``ansible_facts``) should be named ``_info``. General information is non-host specific information, for example information on online/cloud services (you can access different accounts for the same online service from the same host), or information on VMs and containers accessible from the machine.
 
 Please make sure your module meets these requirements before you submit your PR/proposal. If you have questions, reach out via `Ansible's IRC chat channel <http://irc.freenode.net>`_ or the `Ansible development mailing list <https://groups.google.com/group/ansible-devel>`_.