Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add var source_version for ec2_launch_template #56768

Closed
wants to merge 6 commits into from
Closed

Add var source_version for ec2_launch_template #56768

wants to merge 6 commits into from

Conversation

vytran4love
Copy link

@vytran4love vytran4love commented May 22, 2019 •
edited by mattclay

SUMMARY

Add variable source_version, default is "1", which can create or update from specific source version.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ec2_launch_template

@ansibot
Copy link
Contributor

ansibot commented May 22, 2019

@51004143, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 22, 2019
@ansibot
Copy link
Contributor

ansibot commented May 22, 2019

cc @gundalow @mattclay @sivel
click here for bot help

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels May 22, 2019
@ansibot
Copy link
Contributor

ansibot commented May 22, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_launch_template.py:0:0: E309 version_added for new option (source_version) should be '2.9'. Currently StrictVersion ('0.0')

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label May 22, 2019
mattclay
mattclay requested changes May 22, 2019
View reviewed changes
lib/ansible/modules/cloud/amazon/ec2_launch_template.py
source_version:
description:
- Which version should be used when creating or updating launch template? By default, the first version will be made the default.
default: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default: 1
default: 1
version_added: "2.9"

test/sanity/validate-modules/main.py Outdated
@@ -1091,7 +1091,7 @@ def _validate_docs(self):
def _check_version_added(self, doc, existing_doc):
version_added_raw = doc.get('version_added')
try:
version_added = StrictVersion(str(doc.get('version_added', '0.0') or '0.0'))
version_added = StrictVersion(str(doc.get('version_added', '2.9') or '2.9'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module PRs should not make changes to the module validator. Instead, revert this line and add version_added to the new module parameter (see my other comment).

@ansibot ansibot added the feature This issue/PR relates to a feature request. label May 22, 2019
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label May 23, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label May 24, 2019
@ansibot ansibot removed the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label May 24, 2019
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Jun 1, 2019
@ansibot ansibot removed the stale_review Updates were made after the last review and the last review is more than 7 days old. label Jun 25, 2019
@ansibot ansibot added the stale_review Updates were made after the last review and the last review is more than 7 days old. label Jul 3, 2019
@vytran4love vytran4love closed this Jul 9, 2019
@vytran4love vytran4love reopened this Jul 9, 2019
@ansibot ansibot added stale_review Updates were made after the last review and the last review is more than 7 days old. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Jul 9, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 17, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 31, 2020

cc @jillr @s-hertel @tremble
click here for bot help

@ansibot ansibot removed the needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) label Jan 31, 2020
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Mar 3, 2020
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 27, 2020
@ansibot ansibot added collection Related to Ansible Collections work collection:community.aws needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2020

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md

@ansibot ansibot closed this Aug 16, 2020
@ansible ansible locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay requested changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 aws bot_closed bug This issue/PR relates to a bug. cloud collection:community.aws collection Related to Ansible Collections work feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vytran4love @ansibot @mattclay @samdoran