Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add var source_version for ec2_launch_template #56768

Open

Conversation

Projects
None yet
4 participants
@51004143
Copy link

commented May 22, 2019

SUMMARY

Add variable source_version, default is "1", which can create or update from specific source version.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ec2_launch_template

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

@51004143, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

51004143 added some commits May 22, 2019

@ansibot ansibot removed the small_patch label May 22, 2019

51004143 added some commits May 22, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_launch_template.py:0:0: E309 version_added for new option (source_version) should be '2.9'. Currently StrictVersion ('0.0')

click here for bot help

@ansibot ansibot added the ci_verified label May 22, 2019

source_version:
description:
- Which version should be used when creating or updating launch template? By default, the first version will be made the default.
default: 1

This comment has been minimized.

Copy link
@mattclay

mattclay May 22, 2019

Member
Suggested change
default: 1
default: 1
version_added: "2.9"
@@ -1091,7 +1091,7 @@ def _validate_docs(self):
def _check_version_added(self, doc, existing_doc):
version_added_raw = doc.get('version_added')
try:
version_added = StrictVersion(str(doc.get('version_added', '0.0') or '0.0'))
version_added = StrictVersion(str(doc.get('version_added', '2.9') or '2.9'))

This comment has been minimized.

Copy link
@mattclay

mattclay May 22, 2019

Member

Module PRs should not make changes to the module validator. Instead, revert this line and add version_added to the new module parameter (see my other comment).

@ansibot ansibot added the feature label May 22, 2019

@samdoran samdoran removed the needs_triage label May 23, 2019

@ansibot ansibot removed the ci_verified label May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.