ios_ntp: Switch interface to GigabitEthernet0/1 for tests #56964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 26, 2019
Until we get time to debug why centos-7 nodes are slower, use python2.7 from ubuntu-bionic. Depends-On: ansible/ansible#56955 Depends-On: ansible/ansible#56956 Depends-On: ansible/ansible#56958 Depends-On: ansible/ansible#56959 Depends-On: ansible/ansible#56960 Depends-On: ansible/ansible#56964 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
ansibot
added
affects_2.9
|
Pull-request updated, HEAD is now 5432706 |
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 26, 2019
Until we get time to debug why centos-7 nodes are slower, use python2.7 from ubuntu-bionic. Depends-On: ansible/ansible#56955 Depends-On: ansible/ansible#56956 Depends-On: ansible/ansible#56958 Depends-On: ansible/ansible#56959 Depends-On: ansible/ansible#56960 Depends-On: ansible/ansible#56964 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger
added a commit
to pabelanger/ansible-zuul-jobs-1
that referenced
this pull request
May 26, 2019
Until we get time to debug why centos-7 nodes are slower, use python2.7 from ubuntu-bionic. Depends-On: ansible/ansible#56955 Depends-On: ansible/ansible#56956 Depends-On: ansible/ansible#56958 Depends-On: ansible/ansible#56959 Depends-On: ansible/ansible#56960 Depends-On: ansible/ansible#56964 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
danielmellado
approved these changes
May 27, 2019
trishnaguha
reviewed
May 27, 2019
There was a problem hiding this comment.
Instead of hard coding the interface in the test, can we get it from prepare_ios_tests like done in ios_interface https://github.com/ansible/ansible/blob/devel/test/integration/targets/ios_interface/tests/cli/basic.yaml#L6
ansibot
removed
the
needs_triage
Lets use an interface we know that exists for testing, in some cases Loopback0 maybe not be configured. Signed-off-by: Paul Belanger <pabelanger@redhat.com>
This is currently broken, and tests don't work. Fix this by properly registering the result variable. Signed-off-by: Paul Belanger <pabelanger@redhat.com>
|
Pull-request updated, HEAD is now fc0223a |
pabelanger
force-pushed
the
temp/ios_ntp_fixes
branch
from
5432706
to
fc0223a
Compare
|
LGTM with the non hard coded interfaces. |
NilashishC
approved these changes
May 27, 2019
trishnaguha
approved these changes
May 27, 2019
justjais
approved these changes
May 27, 2019
ansibot
added
shipit
pabelanger
added a commit
to pabelanger/ansible
that referenced
this pull request
Jun 12, 2019
) * ios_ntp: Switch interface to GigabitEthernet0/1 for tests Lets use an interface we know that exists for testing, in some cases Loopback0 maybe not be configured. Signed-off-by: Paul Belanger <pabelanger@redhat.com> * ios_ntp: properly register result variable for testing This is currently broken, and tests don't work. Fix this by properly registering the result variable. Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger
added a commit
to pabelanger/ansible
that referenced
this pull request
Jun 12, 2019
) * ios_ntp: Switch interface to GigabitEthernet0/1 for tests Lets use an interface we know that exists for testing, in some cases Loopback0 maybe not be configured. Signed-off-by: Paul Belanger <pabelanger@redhat.com> * ios_ntp: properly register result variable for testing This is currently broken, and tests don't work. Fix this by properly registering the result variable. Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger
added a commit
to pabelanger/ansible
that referenced
this pull request
Jun 12, 2019
) * ios_ntp: Switch interface to GigabitEthernet0/1 for tests Lets use an interface we know that exists for testing, in some cases Loopback0 maybe not be configured. Signed-off-by: Paul Belanger <pabelanger@redhat.com> * ios_ntp: properly register result variable for testing This is currently broken, and tests don't work. Fix this by properly registering the result variable. Signed-off-by: Paul Belanger <pabelanger@redhat.com>
abadger
pushed a commit
that referenced
this pull request
Jun 17, 2019
* ios_ntp: Switch interface to GigabitEthernet0/1 for tests Lets use an interface we know that exists for testing, in some cases Loopback0 maybe not be configured. Signed-off-by: Paul Belanger <pabelanger@redhat.com> * ios_ntp: properly register result variable for testing This is currently broken, and tests don't work. Fix this by properly registering the result variable. Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Update ios_ntp tests with known good interface
ISSUE TYPE
COMPONENT NAME
ansible-test ios_ntp integration