Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for sparse volumes #57354

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@Area128
Copy link

commented Jun 4, 2019

SUMMARY

Allow the creation of sparse volumes (zfs create -s ...)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

zfs

ADDITIONAL INFORMATION

@mator
Copy link
Contributor

left a comment

could use check_type_bool() function instead of a plain check for value, which could be true/false, on/off, 1/0 (including uppercase first character)...

Show resolved Hide resolved lib/ansible/modules/storage/zfs/zfs.py Outdated

@ansibot ansibot removed the needs_triage label Jun 4, 2019

@ansibot ansibot added the stale_ci label Jun 12, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

@Area128 This PR contains @ mentions in at least one commit message. Those mentions can cause cascading notifications through GitHub and need to be removed. Please squash or amend your commits to remove the mentions.

click here for bot help

@Area128 Area128 force-pushed the Area128:zfs-sparse-volume branch from fed3225 to c21d235 Jun 21, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/storage/zfs/zfs.py:170:23: undefined-variable Undefined variable 'check_type_bool'

click here for bot help

@ansibot ansibot added the ci_verified label Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.