Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for sparse volumes #57354

Closed
wants to merge 3 commits into from
Closed

add support for sparse volumes #57354

wants to merge 3 commits into from

Conversation

Area128
Copy link

@Area128 Area128 commented Jun 4, 2019

SUMMARY

Allow the creation of sparse volumes (zfs create -s ...)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

zfs

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jun 4, 2019

cc @bcoca @dagwieers @danowar2k @fishman @jasperla @johanwiren @jpdasma @mator @scathatheworm @troy2914 @xen0l
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. solaris Solaris community storage support:community This issue/PR relates to code supported by the Ansible community. zfs ZFS community labels Jun 4, 2019
mator
mator reviewed Jun 4, 2019
View reviewed changes
Copy link
Contributor

@mator mator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use check_type_bool() function instead of a plain check for value, which could be true/false, on/off, 1/0 (including uppercase first character)...

lib/ansible/modules/storage/zfs/zfs.py Show resolved Hide resolved
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jun 4, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 12, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 20, 2019

@Area128 This PR contains @ mentions in at least one commit message. Those mentions can cause cascading notifications through GitHub and need to be removed. Please squash or amend your commits to remove the mentions.

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 20, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 21, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/storage/zfs/zfs.py:170:23: undefined-variable Undefined variable 'check_type_bool'

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jun 21, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 29, 2019
@Area128
Reverting to simple value check
2d8afc2 
No time to properly test check_type_bool unfortunately. Reverting to simple check which should fine while params go through "reverse boolification" in main() .
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 6, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 14, 2019
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 27, 2020
@ansibot ansibot added collection Related to Ansible Collections work collection:community.general needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2020

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md

@ansibot ansibot closed this Aug 16, 2020
@ansible ansible locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mator mator mator left review comments

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bot_closed collection:community.general collection Related to Ansible Collections work feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. solaris Solaris community stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. storage support:community This issue/PR relates to code supported by the Ansible community. zfs ZFS community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Area128 @ansibot @mator