VMware: fix for vmware_guest_file_operation binary file

[stravassac]

SUMMARY

Fix bug #57475 for copy binary file withon python 3.X

#57475

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

vmware_guest_file_operation

[ansibot]

cc @Akasurde @Tomorrow9 @dav1x @goneri @lparkes @pgbidkar @warthog9
click here for bot help

[Akasurde]

@stravassac Thanks for the PR. Could you please write test case(s) for this change ? Thanks.

needs_info

[stravassac]

@Akasurde, is it enough for you ?

- name: test
  hosts: all
  vars:
    ansible_python_interpreter: "/usr/bin/env python"
    var_my_file: "hostnamectl"
  tasks:
    - name: file
      vmware_guest_file_operation:
        hostname: XXXXXXX
        username: "{{ lookup('env','VMWARE_USER') }}"
        password: "{{ lookup('env','VMWARE_PASSWORD') }}"
        datacenter: XXXXX
        validate_certs: False
        folder: /vm/
        vm_id: test1
        vm_username: root
        vm_password: XXXX
        copy:
          src: "/usr/bin/{{var_my_file}}"
          dest: "/root/{{var_my_file}}"
          #overwrite: True

      delegate_to: localhost

Before fix
TASK [file] ************************************************************************************************************************************************************************************************
fatal: [127.0.0.1]: FAILED! => {"changed": false, "msg": "'utf-8' codec can't decode byte 0xf8 in position 96: invalid start byte"}

after
TASK [file] ************************************************************************************************************************************************************************************************
ok: [127.0.0.1]

It's also work with text file

[jillr]

@stravassac Integration tests should look similar to the other vmware modules, using the prepare_vmware_tests role to setup the test environment and asserts to ensure test outcomes. For example: https://github.com/ansible/ansible/tree/devel/test/integration/targets/vmware_guest_facts. The directory here would be in test/integration/targets/vmware_guest_file_operation.

[goneri]

I would prefer an unit-test for this kind of thing, it will be more efficient and faster. This being said, the fix is obvious.

[Akasurde]

@stravassac Thanks for the contribution.