Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports related to network-integration testing for Cisco IOS #57758

Open
wants to merge 8 commits into
base: stable-2.8
from

Conversation

Projects
None yet
4 participants
@pabelanger
Copy link
Contributor

commented Jun 12, 2019

SUMMARY

Backports needed to fix ios network-integration tests.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-test, ios network-integration

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

@pabelanger

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

recheck

@pabelanger

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Pull-request updated, HEAD is now ea99a5f

@pabelanger pabelanger force-pushed the pabelanger:temp/ios-stable-2.8-fixes branch from 6bdfb0f to ea99a5f Jun 12, 2019

@pabelanger

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Pull-request updated, HEAD is now eb07a00

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

@pabelanger

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Pull-request updated, HEAD is now 33ac67b

@pabelanger

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Pull-request updated, HEAD is now 4fe57de

@pabelanger pabelanger force-pushed the pabelanger:temp/ios-stable-2.8-fixes branch from 33ac67b to 4fe57de Jun 12, 2019

pabelanger added some commits May 25, 2019

Add missing scp dependency for ios_file tests
This was required to be installed by a human, out side of our testing.
Add it so ansible-test can now manage.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Fix syntax issue with ios_ntp tests
This was missing a yaml anchor.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
ansible-test: use become for connection=local on ios_user
ios_user requires escalated privledges, rather then doing this in the
inventory, we can just add it into the playbook tasks.

Also add missing provider settings for authorize.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
ios_ntp: Switch interface to GigabitEthernet0/1 for tests (#56964)
* ios_ntp: Switch interface to GigabitEthernet0/1 for tests

Lets use an interface we know that exists for testing, in some cases
Loopback0 maybe not be configured.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>

* ios_ntp: properly register result variable for testing

This is currently broken, and tests don't work. Fix this by properly
registering the result variable.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Pull-request updated, HEAD is now 384122e

@pabelanger pabelanger force-pushed the pabelanger:temp/ios-stable-2.8-fixes branch from 4fe57de to 384122e Jun 12, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/ios_ntp/tests/cli/ntp_configuration.yaml:107:1: empty-lines too many blank lines (1 > 0)

click here for bot help

@pabelanger

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Pull-request updated, HEAD is now a1c419a

@pabelanger pabelanger force-pushed the pabelanger:temp/ios-stable-2.8-fixes branch from 384122e to a1c419a Jun 12, 2019

@ansibot

This comment has been minimized.

justjais and others added some commits Jun 7, 2019

PR to fix the IOS_NTP integration TC failure (#57481)
* ios_ntp tc fail

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* ios_ntp tc fail

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix for local connection

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Issue55222 (#55223)
* Python 3.7 compatibility for re.Pattern (Fixes #55222)

* Python 3.7 compatibility for re.Pattern (Fixes #55222)
Fix ios_smoke failure
Set ansible_buffer_read_timeout to be larger then
ansible_command_timeout, as both appliance / controller are on the same
physical network and we are not triggering ansible_command_timeout.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Add missing changelog fragments
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Pull-request updated, HEAD is now 4e2b279

@pabelanger pabelanger force-pushed the pabelanger:temp/ios-stable-2.8-fixes branch from a1c419a to 4e2b279 Jun 12, 2019

@pabelanger pabelanger changed the title Pull request for temp/ios-stable-2.8-fixes Backports related to network-integration testing for Cisco IOS Jun 12, 2019

@pabelanger pabelanger changed the title Backports related to network-integration testing for Cisco IOS WIP: Backports related to network-integration testing for Cisco IOS Jun 12, 2019

@ansibot ansibot added the WIP label Jun 12, 2019

@ansible-zuul

This comment has been minimized.

@pabelanger

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

This has also made all of our network-integration testing for IOS green, confirming everything worked as expected.

@pabelanger pabelanger changed the title WIP: Backports related to network-integration testing for Cisco IOS Backports related to network-integration testing for Cisco IOS Jun 12, 2019

@ansibot ansibot removed the WIP label Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.