Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports related to network-integration testing for Cisco IOS #57758

Merged
merged 8 commits into from Jun 17, 2019
Merged

Backports related to network-integration testing for Cisco IOS #57758

merged 8 commits into from Jun 17, 2019

Conversation

pabelanger
Copy link
Contributor

@pabelanger pabelanger commented Jun 12, 2019 •
edited

SUMMARY

Backports needed to fix ios network-integration tests.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-test, ios network-integration

@ansibot
Copy link
Contributor

ansibot commented Jun 12, 2019

cc @mattclay @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Jun 12, 2019
@pabelanger
Copy link
Contributor Author

recheck

@pabelanger
Copy link
Contributor Author

Pull-request updated, HEAD is now ea99a5f

@pabelanger
Copy link
Contributor Author

Pull-request updated, HEAD is now eb07a00

@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 12, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 12, 2019

cc @federico87
click here for bot help

@ansibot ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 12, 2019
@pabelanger
Copy link
Contributor Author

Pull-request updated, HEAD is now 33ac67b

@pabelanger
Copy link
Contributor Author

Pull-request updated, HEAD is now 4fe57de

@pabelanger
Add missing scp dependency for ios_file tests
a3ebdba 
This was required to be installed by a human, out side of our testing.
Add it so ansible-test can now manage.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger
ansible-test: use become for connection=local on ios_user
3e23de6 
ios_user requires escalated privledges, rather then doing this in the
inventory, we can just add it into the playbook tasks.

Also add missing provider settings for authorize.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger
Fix syntax issue with ios_ntp tests
d0b4efe 
This was missing a yaml anchor.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger
ios_ntp: Switch interface to GigabitEthernet0/1 for tests (ansible#56964
6358bcd 
)

* ios_ntp: Switch interface to GigabitEthernet0/1 for tests

Lets use an interface we know that exists for testing, in some cases
Loopback0 maybe not be configured.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>

* ios_ntp: properly register result variable for testing

This is currently broken, and tests don't work. Fix this by properly
registering the result variable.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger
Copy link
Contributor Author

Pull-request updated, HEAD is now 384122e

@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Jun 12, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 12, 2019

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/ios_ntp/tests/cli/ntp_configuration.yaml:107:1: empty-lines too many blank lines (1 > 0)

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 12, 2019
@pabelanger
Copy link
Contributor Author

Pull-request updated, HEAD is now a1c419a

@ansibot
Copy link
Contributor

ansibot commented Jun 12, 2019

cc @NilashishC @Qalthos @ganeshrn @gdpak @justjais
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 12, 2019
justjais and others added 4 commits June 12, 2019 14:37
@justjais @pabelanger
PR to fix the IOS_NTP integration TC failure (ansible#57481)
fe49225 
* ios_ntp tc fail

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* ios_ntp tc fail

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix for local connection

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger
Fix ios_smoke failure
a296ce5 
Set ansible_buffer_read_timeout to be larger then
ansible_command_timeout, as both appliance / controller are on the same
physical network and we are not triggering ansible_command_timeout.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@ajsiersema @pabelanger
Issue55222 (ansible#55223)
693e1a0 
* Python 3.7 compatibility for re.Pattern (Fixes ansible#55222)

* Python 3.7 compatibility for re.Pattern (Fixes ansible#55222)
@pabelanger
Add missing changelog fragments
4e2b279 
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger
Copy link
Contributor Author

Pull-request updated, HEAD is now 4e2b279

@pabelanger pabelanger changed the title Pull request for temp/ios-stable-2.8-fixes Backports related to network-integration testing for Cisco IOS Jun 12, 2019
@pabelanger pabelanger changed the title Backports related to network-integration testing for Cisco IOS WIP: Backports related to network-integration testing for Cisco IOS Jun 12, 2019
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Jun 12, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Jun 12, 2019

Build succeeded (third-party-check pipeline).

@pabelanger
Copy link
Contributor Author

This has also made all of our network-integration testing for IOS green, confirming everything worked as expected.

@pabelanger pabelanger changed the title WIP: Backports related to network-integration testing for Cisco IOS Backports related to network-integration testing for Cisco IOS Jun 12, 2019
@ansibot ansibot removed the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Jun 12, 2019
@pabelanger
Copy link
Contributor Author

recheck

@ansible-zuul
Copy link

ansible-zuul bot commented Jun 17, 2019

Build succeeded (third-party-check pipeline).

@abadger abadger merged commit 335c202 into ansible:stable-2.8 Jun 17, 2019
@abadger
Copy link
Contributor

abadger commented Jun 17, 2019

Merged for the 2.8.2 release.

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jun 18, 2019
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pabelanger @ansibot @abadger @sivel @justjais @ajsiersema