vmware_guest: assign device keys from a sequence generator

[lparkes]

SUMMARY

This PR adds a new class which contains a staticmethod that generates a sequence of integers for use as temporary client defined keys. I'm not convinced that the current system of ranges of random numbers will cope with assigning keys to disks and disks will need keys when we start using storage policies.

I'm using this PR to help discuss what we want to do.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

vmware_guest

ADDITIONAL INFORMATION

1. The most important thing is assigning keys to disks. The storage policy API doesn't work if keys aren't specified even though the API doesn't refer to the keys directly.
2. I kind of like the staticmethod for generating keys because it makes keys that look like the keys made by the VMware client.
3. I don't care at all what class the staticmethod is part of and there is no good reason for making the new class PyVmomiKeyHelper.

[ansibot]

cc @Akasurde @Tomorrow9 @dav1x @goneri @nerzhul @pdellaert @pgbidkar @warthog9
click here for bot help

[ansibot]

@lparkes, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

[ansibot]

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest.py:612:1: E302 expected 2 blank lines, found 1

click here for bot help

[lparkes]

I don't recall saving this PR last night. That could easily have been kitten assisted and I have tidied up the text and I'll look at the pep8 failure now.

[goneri]

I like the idea, but I'm not sure you need a class for that. e.g:

>>> def foo():
...     if hasattr(foo, 'cpt'):
...         foo.cpt +=1
...     else:
...         foo.cpt = 0
...     return foo.cpt
... 
>>> foo()
0
>>> foo()
1
>>> foo()
2

[ansibot]

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

• lib/ansible/modules/cloud/vmware/vmware_guest.py -> https://galaxy.ansible.com/community/vmware

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md