Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aci_l3out_extsubnet.py #58087

Merged
merged 5 commits into from Aug 27, 2019
Merged

Add aci_l3out_extsubnet.py #58087

merged 5 commits into from Aug 27, 2019

Conversation

sig9org
Copy link
Contributor

@sig9org sig9org commented Jun 19, 2019

SUMMARY

Implementation of ACI External Subnet module.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

aci_extsubnet.py

ADDITIONAL INFORMATION

Tested on 4.1(2g).

@ansibot
Copy link
Contributor

ansibot commented Jun 19, 2019

@brunocalogero @devarshishah3 @fadallar @jmcgill298 @koladiya @mtorelli @rost-d @rsmeyers @schunduri @sgerhart @smnmtzgr @tknipper11

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jun 19, 2019

cc @brunocalogero @dagwieers @devarshishah3 @fadallar @jmcgill298 @koladiya @mtorelli @rsmeyers @schunduri @smnmtzgr
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jun 19, 2019

@sig9org, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added aci Cisco ACI community affects_2.9 This issue/PR affects Ansible v2.9 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Jun 19, 2019
@sig9org
Copy link
Contributor Author

sig9org commented Jun 24, 2019

Hi,

Do you need anything to merge?
Please let me know if there is a shortage.

Regards,

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 2, 2019
devarshishah3
devarshishah3 suggested changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@devarshishah3 devarshishah3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the naming convention of the module to aci_l3out_extsubnet.

Add a note to specify the tested version in the comments in the module

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Aug 16, 2019
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Aug 24, 2019
@dagwieers
Rename to aci_l3out_extsubnet
c9cfeae 
As suggested during review.
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 27, 2019
@ansibot

This comment has been minimized.

Sign in to view
@dagwieers dagwieers changed the title Add aci_extsubnet.py Add aci_l3out_extsubnet.py Aug 27, 2019
@dagwieers dagwieers merged commit b563f7f into ansible:devel Aug 27, 2019
@dagwieers
Copy link
Contributor

Thanks !

adharshsrivatsr pushed a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
@sig9org @adharshsrivatsr
Add aci_l3out_extsubnet.py (ansible#58087)
7f72256 
* Add aci_extsubnet.py

* Fix aliases of network option

* Shorten the sentence

* Rename to aci_l3out_extsubnet

As suggested during review.

* Rename module
anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
@sig9org @anas-shami
Add aci_l3out_extsubnet.py (ansible#58087)
5eacc30 
* Add aci_extsubnet.py

* Fix aliases of network option

* Shorten the sentence

* Rename to aci_l3out_extsubnet

As suggested during review.

* Rename module
@ansible ansible locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devarshishah3 devarshishah3 devarshishah3 requested changes

Assignees
No one assigned
Labels
aci Cisco ACI community affects_2.9 This issue/PR affects Ansible v2.9 cisco Cisco technologies module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sig9org @ansibot @dagwieers @devarshishah3