Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport/2.8/55218 #58639

Merged
merged 2 commits into from Jul 16, 2019
Merged

Backport/2.8/55218 #58639

merged 2 commits into from Jul 16, 2019

Conversation

ajsiersema
Copy link
Contributor

SUMMARY

Deleting a Cisco IOS macro fails because the "no macro" command was erroneously handled by edit_macro()
Fixes #55212

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_config

ADDITIONAL INFORMATION

STEPS TO REPRODUCE
Try to send a 'no macro name <my_macro_name>' line with ios_config

ios_config:
  lines: "no macro name {{ macro_name }}"

EXPECTED RESULTS
Macro deleted/undefined on device.

ACTUAL RESULTS
ios_config fails.

@ansibot
Copy link
Contributor

ansibot commented Jul 2, 2019

cc @justjais @privateip
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 2, 2019

@ajsiersema, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jul 2, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Jul 2, 2019

Build succeeded (third-party-check pipeline).

pabelanger
pabelanger reviewed Jul 3, 2019
View reviewed changes
Copy link
Contributor

@pabelanger pabelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any tests for this?

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 3, 2019
@ajsiersema
Copy link
Contributor Author

Do we have any tests for this?

I'd think there's no need for extra specific tests : "no macro name" is a regular configuration command, it doesn't need any special treatment, i.e. it shouldn't be handled by edit_macro()
Please review the minimal changes to get the idea:
https://github.com/ansible/ansible/pull/55218/files

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 11, 2019
@abadger abadger merged commit db7c82e into ansible:stable-2.8 Jul 16, 2019
@abadger
Copy link
Contributor

abadger commented Jul 16, 2019

Merged for the 2.8.3 release.

@ajsiersema ajsiersema deleted the backport/2.8/55218 branch July 23, 2019 08:02
@ansible ansible locked and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pabelanger pabelanger pabelanger left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community module This issue/PR relates to a module. networking Network category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ajsiersema @ansibot @abadger @pabelanger