Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/2.8/55218 #58639

Merged
merged 2 commits into from Jul 16, 2019

Conversation

Projects
None yet
4 participants
@ajsiersema
Copy link
Contributor

commented Jul 2, 2019

SUMMARY

Deleting a Cisco IOS macro fails because the "no macro" command was erroneously handled by edit_macro()
Fixes #55212

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_config

ADDITIONAL INFORMATION

STEPS TO REPRODUCE
Try to send a 'no macro name <my_macro_name>' line with ios_config

ios_config:
  lines: "no macro name {{ macro_name }}"

EXPECTED RESULTS
Macro deleted/undefined on device.

ACTUAL RESULTS
ios_config fails.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

@ajsiersema, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansible-zuul

This comment has been minimized.

Copy link

commented Jul 2, 2019

Build succeeded (third-party-check pipeline).

@pabelanger
Copy link
Contributor

left a comment

Do we have any tests for this?

@ansibot ansibot removed the needs_triage label Jul 3, 2019

@ajsiersema

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

Do we have any tests for this?

I'd think there's no need for extra specific tests : "no macro name" is a regular configuration command, it doesn't need any special treatment, i.e. it shouldn't be handled by edit_macro()
Please review the minimal changes to get the idea:
https://github.com/ansible/ansible/pull/55218/files

@ansibot ansibot added the stale_ci label Jul 11, 2019

@abadger abadger merged commit db7c82e into ansible:stable-2.8 Jul 16, 2019

2 checks passed

Shippable Run 130501 status is SUCCESS.
Details
ansible/third-party-check third-party-check status: success
Details
@abadger

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

Merged for the 2.8.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.