Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃 Add an initial config for the lockdown bot #58674

Closed
wants to merge 1 commit into from
Closed

馃 Add an initial config for the lockdown bot #58674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/lock.yml
View file
Open in desktop
@@ -0,0 +1,29 @@
# Number of days of inactivity before a closed issue or pull request is locked
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean that if people comment/spam on closed issues then the issue remains unlocked? I thought we wanted Number of days since closure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. But it's better than nothing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation does use number of days since last updated:

https://github.com/dessant/lock-threads/blob/8b1ae9c84a4219662ad2dd4efec00b0888b23cf6/src/lock.js#L69

Using last closed for the query instead should be possible with modifications to the bot:

https://help.github.com/en/articles/searching-issues-and-pull-requests#search-by-when-an-issue-or-pull-request-was-closed

To keep existing auto-close behavior we should see if we can get an upstream change to the bot to support filtering based on closed date.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be possible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattclay @mkrizek dessant/lock-threads#14 (comment)

daysUntilLock: 365

# Issues and pull requests with these labels will not be locked.
exemptLabels: []

# Label to add before locking, such as `outdated`. Set to `false` to disable
lockLabel: "S: auto-locked"

# Comment to post before locking. Set to `false` to disable
lockComment: false

# Assign `resolved` as the reason for locking. Set to `false` to disable
setLockReason: true

# Limit to only `issues` or `pulls`
# only: issues

# Optionally, specify configuration settings just for `issues` or `pulls`
# issues:
# exemptLabels:
# - help-wanted
# lockLabel: outdated

# pulls:
# daysUntilLock: 30

# Repository to extend settings from
# _extends: repo